Deprecate EnumFlagsAttribute in favor of FlagsPropertyAttribute#1075
Open
keveleigh wants to merge 4 commits intoMixedRealityToolkit:feature/XRI3from
Open
Deprecate EnumFlagsAttribute in favor of FlagsPropertyAttribute#1075keveleigh wants to merge 4 commits intoMixedRealityToolkit:feature/XRI3from
keveleigh wants to merge 4 commits intoMixedRealityToolkit:feature/XRI3from
Conversation
keveleigh
force-pushed
the
deprecate-flags-attribute
branch
from
0659d2a to
062cbe5
Compare
keveleigh
force-pushed
the
deprecate-flags-attribute
branch
from
062cbe5 to
105fc8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity.XR.CoreUtils.GUIprovidesFlagsPropertyAttributewhich serves the same purpose asEnumFlagsAttribute. In fact...the custom property drawer forEnumFlagsAttributedoesn't appear to have been ported over from MRTK2, so it wasn't really doing anything anyway 🤷 which then meant it was causing an exception, which might be new in Unity 2022, as I don't recall seeing it previously: