Improve fallback logic in PinchInputReader.cs#1041
Draft
keveleigh wants to merge 5 commits intoMixedRealityToolkit:feature/XRI3from
Draft
Improve fallback logic in PinchInputReader.cs#1041keveleigh wants to merge 5 commits intoMixedRealityToolkit:feature/XRI3from
keveleigh wants to merge 5 commits intoMixedRealityToolkit:feature/XRI3from
Conversation
keveleigh
commented
Jul 11, 2025
| } | ||
|
|
||
| value = m_fallbackState.value; | ||
| return value > 0; |
Contributor
Author
There was a problem hiding this comment.
FYI @whebertML, wanted to make sure this doesn't affect the intent of #852
whitetigerhelix
approved these changes
Jul 16, 2025
e43defb to
44c1f48
Compare
44c1f48 to
d70cfff
Compare
d70cfff to
19a2adc
Compare
Hand joints are likely better than a 0 or 1 conversion
19a2adc to
f367c11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasPinchDatato compare against the value instead, to better represent the Unity methodIsInProgress()when going through the fallback path.khr/simple_controller, that doesn't have both a bool and float action for select.