Skip to content

feat: Configurable Intervals#4114

Open
MrGadget1024 wants to merge 3 commits into
masterfrom
ConfigurableIntervals
Open

feat: Configurable Intervals#4114
MrGadget1024 wants to merge 3 commits into
masterfrom
ConfigurableIntervals

Conversation

@MrGadget1024

Copy link
Copy Markdown
Collaborator
image

@MrGadget1024
MrGadget1024 requested a review from miwarnec June 20, 2026 07:45
@MrGadget1024 MrGadget1024 added enhancement New feature or request Awaiting Review labels Jun 20, 2026
@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.25%. Comparing base (370582a) to head (8d33dd1).

Files with missing lines Patch % Lines
Assets/Mirror/Core/NetworkManager.cs 61.53% 5 Missing ⚠️
Assets/Mirror/Core/NetworkServer.cs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4114      +/-   ##
==========================================
+ Coverage   42.24%   42.25%   +0.01%     
==========================================
  Files         156      156              
  Lines       15108    15123      +15     
==========================================
+ Hits         6382     6390       +8     
- Misses       8726     8733       +7     
Flag Coverage Δ
unittests 42.25% <83.33%> (+0.01%) ⬆️
unity-6000.5.1f1 42.25% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Assets/Mirror/Core/NetworkClient.cs 93.81% <100.00%> (+0.01%) ⬆️
Assets/Mirror/Core/NetworkConnectionToClient.cs 100.00% <100.00%> (ø)
Assets/Mirror/Core/NetworkTime.cs 88.46% <100.00%> (ø)
Assets/Mirror/Core/NetworkServer.cs 68.56% <92.85%> (+0.09%) ⬆️
Assets/Mirror/Core/NetworkManager.cs 42.24% <61.53%> (+0.38%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miwarnec

Copy link
Copy Markdown
Collaborator

need more time on this, gonna test in a production game soon to make sure it doesnt break anything

@miwarnec

Copy link
Copy Markdown
Collaborator

@copilot solve merge conflicts

Copilot AI commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@copilot solve merge conflicts

Merge conflicts resolved. Both NetworkClient.cs and NetworkServer.cs had conflicts around TimeSnapshotMessage sends — master added a scaledTime field while our branch added the tickInterval gating. The resolution keeps both: the interval check from this PR and the { scaledTime = NetworkTime.localScaledTime } from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting Review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants