Skip to content

GEOPY-2813: Triangulation crash on input surface #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domfournier wants to merge 2 commits into
base: release/GA_4.8
Choose a base branch
from
Open

GEOPY-2813: Triangulation crash on input surface #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7de2ac6
Use triangulation if available to 1D
domfournier Apr 28, 2026
15470c9
Re-adjust target
domfournier Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions simpeg_drivers/electromagnetics/base_1d_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from discretize.utils import mesh_utils
from geoapps_utils.utils.locations import topo_drape_elevation
from geoh5py import Workspace
from geoh5py.objects import Surface
from geoh5py.shared.merging.drape_model import DrapeModelMerger
from geoh5py.ui_json.ui_json import fetch_active_workspace
from numpy import ndarray
Expand Down Expand Up @@ -48,6 +49,9 @@ def __init__(self, workspace: Workspace, **kwargs):
self.topo_z_drape = topo_drape_elevation(
self.params.data_object.vertices,
self.inversion_topography.locations,
triangulation=self.params.active_cells.topography_object.cells
if isinstance(self.params.active_cells.topography_object, Surface)
else None,
)
Comment thread
domfournier marked this conversation as resolved.

@property
Expand Down
2 changes: 1 addition & 1 deletion tests/run_tests/driver_airborne_fem_1d_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
# To test the full run and validate the inversion.
# Move this file out of the test directory and run.

target_run = {"data_norm": 380.3510229653626, "phi_d": 33100, "phi_m": 209}
target_run = {"data_norm": 381.0495293422212, "phi_d": 33400, "phi_m": 198}
Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahahah, I guess that's good.
But could you just explain why those small differences?
The original function did not changed right?



def test_fem_fwr_1d_run(
Expand Down
Loading