Skip to content

GEOPY-2773: Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted#392

Open
domfournier wants to merge 12 commits intorelease/GA_4.8from
GEOPY-2773
Open

GEOPY-2773: Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted#392
domfournier wants to merge 12 commits intorelease/GA_4.8from
GEOPY-2773

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented Apr 28, 2026

GEOPY-2773 - Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted

Copilot AI review requested due to automatic review settings April 28, 2026 21:26
@github-actions github-actions Bot changed the title GEOPY-2773 GEOPY-2773: Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted Apr 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Frequency-Domain EM (FDEM/FEM) pipeline to support coaxial vs coplanar configurations (per-frequency via survey metadata) and simplifies FDEM channel handling to “real/imag” instead of separate vertical/inline/crossline channel sets. It also updates UI JSON assets and test expectations to match the new naming and metadata.

Changes:

  • Add per-frequency Coaxial data handling and propagate it into receiver/source construction and normalization.
  • Switch FDEM option and output naming from *_vertical_* style channels to real/imag channels.
  • Update UI JSON definitions and tests to reflect the new channel names and metadata.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
tests/run_tests/oriented_airborne_fem_receiver_test.py Adjusts orientation test to new Iteration_0_real grouping and introduces coaxial metadata in the synthetic survey.
tests/run_tests/driver_airborne_fem_test.py Updates test data/uncertainty wiring and expected entity names to real/imag.
simpeg_drivers/utils/synthetics/surveys/frequency_domain/fdem.py Changes “Tx frequency” to referenced indices with a value_map back to true frequencies.
simpeg_drivers/electromagnetics/frequency_domain/options.py Adds coaxial metadata accessor, updates channel option fields to real/imag, and changes caching behavior.
simpeg_drivers/components/factories/survey_factory.py Builds per-frequency receiver orientation suffixes (_coaxial/_coplanar) and updates ordering/source construction.
simpeg_drivers/components/factories/source_factory.py Passes FDEM source orientation derived from receivers (coaxial/coplanar).
simpeg_drivers/components/factories/receiver_factory.py Adds coaxial/coplanar orientation mapping and changes component parsing rules.
simpeg_drivers/components/data.py Updates FDEM normalization to distinguish coaxial vs coplanar scaling.
simpeg_drivers-assets/uijson/fdem_inversion.ui.json Replaces multiple component channels with real/imag channels and updates tooltips.
simpeg_drivers-assets/uijson/fdem_forward.ui.json Same as inversion UI JSON: switches to real/imag and updates tooltips.
simpeg_drivers-assets/uijson/fdem1d_inversion.ui.json Renames 1D channel keys to vertical_* variants (from z_*).
simpeg_drivers-assets/uijson/fdem1d_forward.ui.json Renames 1D channel bool keys to vertical_* variants (from z_*).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpeg_drivers-assets/uijson/fdem_forward.ui.json
Comment thread tests/run_tests/oriented_airborne_fem_receiver_test.py
Comment thread simpeg_drivers/components/factories/survey_factory.py
Comment thread simpeg_drivers/components/factories/survey_factory.py
Comment thread simpeg_drivers/components/factories/receiver_factory.py
Comment thread simpeg_drivers/electromagnetics/frequency_domain/options.py
Comment thread simpeg_drivers/electromagnetics/frequency_domain/options.py
Comment thread simpeg_drivers-assets/uijson/fdem_inversion.ui.json
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (f8dca34) to head (dc2c9e0).

Files with missing lines Patch % Lines
...ivers/electromagnetics/frequency_domain/options.py 80.00% 4 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/GA_4.8     #392      +/-   ##
==================================================
- Coverage           90.17%   90.14%   -0.03%     
==================================================
  Files                 129      129              
  Lines                6474     6475       +1     
  Branches              817      818       +1     
==================================================
- Hits                 5838     5837       -1     
- Misses                422      425       +3     
+ Partials              214      213       -1     
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 93.15% <100.00%> (+0.07%) ⬆️
...g_drivers/components/factories/receiver_factory.py 90.26% <100.00%> (+0.35%) ⬆️
...peg_drivers/components/factories/source_factory.py 90.58% <100.00%> (+0.11%) ⬆️
...peg_drivers/components/factories/survey_factory.py 94.94% <100.00%> (-0.11%) ⬇️
...rs/electromagnetics/frequency_domain_1d/options.py 100.00% <100.00%> (ø)
.../utils/synthetics/surveys/frequency_domain/fdem.py 88.57% <100.00%> (ø)
...ivers/electromagnetics/frequency_domain/options.py 89.85% <80.00%> (-4.52%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what happens here (I don't even know the goal of the app)
No comments about logic/mechanism/docstrings, as it's mostly replacement.
I guess it should be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants