Skip to content

GEOPY-2833: Regularization parameters of sub-drivers always over-written by joint parameters #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domfournier wants to merge 26 commits into
base: release/GA_4.8
Choose a base branch
from
Open

GEOPY-2833: Regularization parameters of sub-drivers always over-written by joint parameters #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ab48c34
Fix issue with tile_spatial
domfournier Apr 1, 2026
d63c55d
Add icons to Option classes
domfournier Apr 1, 2026
07037e8
MOdify test to hit issue
domfournier Apr 24, 2026
ec1a15d
Merge branch 'release/GA_4.8' into GEOPY-2739
domfournier Apr 24, 2026
1478777
Over the start method. Start using UIJson class
domfournier Apr 24, 2026
e2bb6f4
Update test to check values
domfournier Apr 24, 2026
07b9f5a
Augment test
domfournier Apr 24, 2026
85c1424
Remove unrecognized uuids
domfournier Apr 24, 2026
b397dcf
Issue issues in mvi pde uijson
domfournier Apr 24, 2026
623d275
Fix more uijson
domfournier Apr 25, 2026
28e6538
Add temporary implementation of Options.write_ui_json with UIJson
domfournier Apr 25, 2026
5a5aa90
Special models for 2D without y models
domfournier Apr 25, 2026
49edce4
Fix joint cross test
domfournier Apr 25, 2026
bb202ba
Fix sens_wts_threshold to keep test target
domfournier Apr 25, 2026
77a40c7
Remove InputFile from plate_match
domfournier Apr 25, 2026
ab80337
Continue removing InputFile
domfournier Apr 26, 2026
c79f95d
Merge branch 'GEOPY-2731' into GEOPY-2833
domfournier Apr 27, 2026
084059f
Finish removing InputFile from tests
domfournier Apr 27, 2026
21741bf
Re-implement BaseUIJson.read to deal with bad legacy files.
domfournier Apr 27, 2026
9b37b28
Bring back Ground mag option
domfournier Apr 27, 2026
a429e3f
Add airborne and ground gravity survey in meshTypes
domfournier Apr 27, 2026
08aea3d
Docstrings
domfournier Apr 28, 2026
34f67df
Suppress parent from tile_spatial form
domfournier Apr 28, 2026
3b92bd8
Fix start method of plate_match, run test the start
domfournier Apr 29, 2026
5fb7c67
Log the error from the start
domfournier Apr 29, 2026
73e3ffb
Fixes from copilot
domfournier Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/apparent_conductivity_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/apparent_conductivity_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,9 +514,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/direct_current_3d_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/direct_current_3d_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,9 +499,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/fdem1d_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/fdem1d_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,9 +538,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/fdem_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/fdem_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,9 +697,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/gravity_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
12 changes: 3 additions & 9 deletions simpeg_drivers-assets/uijson/gravity_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"{6a057fdc-b355-11e3-95be-fd84a7ffcb88}",
"{f26feba3-aded-494b-b9e9-b2bbcbe298e1}",
"{48f5054a-1c5c-4ca4-9048-80f36dc60a06}",
"{b020a277-90e2-4cd7-84d6-612ee3f25051}"
"{b020a277-90e2-4cd7-84d6-612ee3f25051}",
"{b54f6be6-0eb5-4a4e-887a-ba9d276f9a83}",
"{5ffa3816-358d-4cdd-9b7d-e1f7f5543e05}"
],
"value": ""
},
Expand Down Expand Up @@ -758,14 +760,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"dataType": "Float",
"association": [
"Vertex",
"Cell"
],
"value": 1,
"min": 1,
"max": 1000,
Expand Down
11 changes: 10 additions & 1 deletion simpeg_drivers-assets/uijson/induced_polarization_2d_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,16 @@
"tooltip": "Direct solver to use for the forward calculations",
"value": "Pardiso"
},
"tile_spatial": 1,
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"value": 1,
"min": 1,
"max": 1000,
"verbose": 2,
"visible": false,
"tooltip": "Splits the objective function into spatial tiles for distributed computation using the Dask library"
},
"store_sensitivities": {
"choiceList": [
"disk",
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/induced_polarization_3d_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/induced_polarization_3d_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,9 +515,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/magnetic_scalar_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/magnetic_scalar_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,9 +791,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
10 changes: 4 additions & 6 deletions simpeg_drivers-assets/uijson/magnetic_vector_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@
"{6a057fdc-b355-11e3-95be-fd84a7ffcb88}",
"{f26feba3-aded-494b-b9e9-b2bbcbe298e1}",
"{48f5054a-1c5c-4ca4-9048-80f36dc60a06}",
"{b020a277-90e2-4cd7-84d6-612ee3f25051}"
"{b020a277-90e2-4cd7-84d6-612ee3f25051}",
"{4b99204c-d133-4579-a916-a9c8b98cfccb}",
"{028e4905-cc97-4dab-b1bf-d76f58b501b5}"
],
"value": "",
"optional": true,
Expand Down Expand Up @@ -98,8 +100,7 @@
"{f26feba3-aded-494b-b9e9-b2bbcbe298e1}",
"{48f5054a-1c5c-4ca4-9048-80f36dc60a06}",
"{b020a277-90e2-4cd7-84d6-612ee3f25051}",
"{4b99204c-d133-4579-a916-a9c8b98cfccb}",
"{028e4905-cc97-4dab-b1bf-d76f58b501b5}"
"{4b99204c-d133-4579-a916-a9c8b98cfccb}"
],
"value": ""
},
Expand Down Expand Up @@ -232,9 +233,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/magnetic_vector_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,9 +839,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
10 changes: 4 additions & 6 deletions simpeg_drivers-assets/uijson/magnetic_vector_pde_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
"{6a057fdc-b355-11e3-95be-fd84a7ffcb88}",
"{f26feba3-aded-494b-b9e9-b2bbcbe298e1}",
"{48f5054a-1c5c-4ca4-9048-80f36dc60a06}",
"{b020a277-90e2-4cd7-84d6-612ee3f25051}"
"{b020a277-90e2-4cd7-84d6-612ee3f25051}",
"{028e4905-cc97-4dab-b1bf-d76f58b501b5}"
],
"value": "",
"optional": true,
Expand Down Expand Up @@ -98,8 +99,7 @@
"{f26feba3-aded-494b-b9e9-b2bbcbe298e1}",
"{48f5054a-1c5c-4ca4-9048-80f36dc60a06}",
"{b020a277-90e2-4cd7-84d6-612ee3f25051}",
"{4b99204c-d133-4579-a916-a9c8b98cfccb}",
"{028e4905-cc97-4dab-b1bf-d76f58b501b5}"
"{4b99204c-d133-4579-a916-a9c8b98cfccb}"
],
"value": ""
},
Expand Down Expand Up @@ -196,13 +196,11 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
"verbose": 2,
"visible": false,
"tooltip": "Splits the objective function into spatial tiles for distributed computation using the Dask library"
},
"max_chunk_size": {
Expand Down
4 changes: 1 addition & 3 deletions simpeg_drivers-assets/uijson/magnetic_vector_pde_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,13 +627,11 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
"verbose": 2,
"visible": false,
"tooltip": "Splits the objective function into spatial tiles for distributed computation using the Dask library"
},
"out_group": {
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/magnetotellurics_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/magnetotellurics_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,9 +728,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
5 changes: 2 additions & 3 deletions simpeg_drivers-assets/uijson/plate_sweep.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,17 @@
"main": true,
"group": "Base",
"label": "Output directory",
"directoryOnly": true,
"enabled": false,
"optional": true,
"tootip": "Directory to store simulation results, relative to the working geoh5.",
"tooltip": "Directory to store simulation results, relative to the working geoh5.",
"value": "./simulations"
},
"generate_summary": {
"main": true,
"group": "Base",
"label": "Generate summary file (.xlsx)",
"enabled": true,
"tootip": "Create an xlsx file summarizing the parameters of all simulations found in the 'Output directory'.",
"tooltip": "Create an xlsx file summarizing the parameters of all simulations found in the 'Output directory'.",
"value": true
},
"background_start": {
Expand Down
5 changes: 1 addition & 4 deletions simpeg_drivers-assets/uijson/tdem1d_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"<dt>Wire</dt><dd>Current * number of turns (NI).</dd>",
"</dl>"
],
"value": "dB/dt (T/s)"
"value": "Airborne dB/dt (V/Am^4)"
},
"z_channel_bool": {
"group": "Survey",
Expand Down Expand Up @@ -192,9 +192,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
5 changes: 1 addition & 4 deletions simpeg_drivers-assets/uijson/tdem1d_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"<dt>Wire</dt><dd>Current * number of turns (NI).</dd>",
"</dl>"
],
"value": "dB/dt (T/s)"
"value": "Airborne dB/dt (V/Am^4)"
},
"z_channel": {
"association": [
Expand Down Expand Up @@ -520,9 +520,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
5 changes: 1 addition & 4 deletions simpeg_drivers-assets/uijson/tdem_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"<dt>Wire</dt><dd>Current * number of turns (NI).</dd>",
"</dl>"
],
"value": "dB/dt (T/s)"
"value": "Airborne dB/dt (V/Am^4)"
},
"vertical_channel_bool": {
"group": "Survey",
Expand Down Expand Up @@ -187,9 +187,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
5 changes: 1 addition & 4 deletions simpeg_drivers-assets/uijson/tdem_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"<dt>Wire</dt><dd>Current * number of turns (NI).</dd>",
"</dl>"
],
"value": "dB/dt (T/s)"
"value": "Airborne dB/dt (V/Am^4)"
},
"vertical_channel": {
"association": [
Expand Down Expand Up @@ -604,9 +604,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
3 changes: 0 additions & 3 deletions simpeg_drivers-assets/uijson/tipper_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,6 @@
"tile_spatial": {
"group": "Compute",
"label": "Number of tiles",
"parent": "data_object",
"isValue": true,
"property": "",
"value": 1,
"min": 1,
"max": 1000,
Expand Down
Loading
Loading