GEOPY-2826: Plate match parallel process fails without good error log#384
Merged
domfournier merged 11 commits intorelease/GA_4.8from Apr 23, 2026
Merged
GEOPY-2826: Plate match parallel process fails without good error log#384domfournier merged 11 commits intorelease/GA_4.8from
domfournier merged 11 commits intorelease/GA_4.8from
Conversation
# Conflicts: # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # environments/py-3.13-linux-64-dev.conda.lock.yml # environments/py-3.13-linux-64.conda.lock.yml # environments/py-3.13-win-64-dev.conda.lock.yml # environments/py-3.13-win-64.conda.lock.yml # environments/py-3.14-linux-64-dev.conda.lock.yml # environments/py-3.14-linux-64.conda.lock.yml # environments/py-3.14-win-64-dev.conda.lock.yml # environments/py-3.14-win-64.conda.lock.yml # py-3.12.conda-lock.yml # py-3.13.conda-lock.yml # py-3.14.conda-lock.yml
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates driver resolution to use a new driver_class_from_dict helper (supporting run_command-based UI JSONs), adjusts plate simulation sweep/match behavior, and refreshes dependency pins/lockfiles for the GA_4.8 release alignment.
Changes:
- Replace legacy driver lookup (
from_input_file) withdriver_class_from_dictacross runtime entry points and tests. - Simplify/remove plate sweep/match UIJson Pydantic models and adjust sweep/match driver logic.
- Update build/dependency configuration and regenerate conda-lock environments (including new py-3.14 locks).
Reviewed changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/uijson_test.py | Updates UI JSON driver-class resolution to use driver_class_from_dict. |
| tests/run_tests/driver_joint_pgi_homogeneous_test.py | Adjusts test setup to match newer JSON option expectations. |
| simpeg_drivers/utils/utils.py | Introduces driver_class_from_dict / moves driver_class_from_name; updates group-to-driver creation. |
| simpeg_drivers/plate_simulation/sweep/uijson.py | Removes legacy sweep UIJson model. |
| simpeg_drivers/plate_simulation/sweep/options.py | Tightens sweep parameter types and adds legacy workdir handling. |
| simpeg_drivers/plate_simulation/sweep/driver.py | Delegates start() to base implementation and expands group detection logic. |
| simpeg_drivers/plate_simulation/options.py | Switches plate simulation parameter dispatch to driver_class_from_dict. |
| simpeg_drivers/plate_simulation/match/uijson.py | Removes legacy match UIJson model. |
| simpeg_drivers/plate_simulation/match/driver.py | Sets headless matplotlib backend and modifies plate placement/scoring logic. |
| simpeg_drivers/plate_simulation/driver.py | Rehomes driver_class_from_name import to new location. |
| simpeg_drivers/options.py | Sets a default documentation URL in CoreOptions. |
| simpeg_drivers/driver.py | Removes from_input_file and uses driver_class_from_dict in the CLI entry. |
| pyproject.toml | Updates VCS dependency refs to GA_4.8 release branches and tweaks build requirements. |
| py-3.13.conda-lock.yml | Regenerated lock with updated package versions/resolutions. |
| py-3.12.conda-lock.yml | Regenerated lock with updated package versions/resolutions. |
| environments/py-3.14-win-64.conda.lock.yml | Adds new py3.14 Windows lockfile. |
| environments/py-3.14-win-64-dev.conda.lock.yml | Adds new py3.14 Windows dev lockfile. |
| environments/py-3.14-linux-64.conda.lock.yml | Adds new py3.14 Linux lockfile. |
| environments/py-3.14-linux-64-dev.conda.lock.yml | Adds new py3.14 Linux dev lockfile. |
| environments/py-3.13-*.conda.lock.yml | Updates existing py3.13 environment lockfiles. |
| environments/py-3.12-*.conda.lock.yml | Updates existing py3.12 environment lockfiles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/GA_4.8 #384 +/- ##
==================================================
- Coverage 90.26% 90.21% -0.05%
==================================================
Files 132 129 -3
Lines 6469 6472 +3
Branches 814 816 +2
==================================================
Hits 5839 5839
- Misses 420 421 +1
- Partials 210 212 +2
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # environments/py-3.13-linux-64-dev.conda.lock.yml # environments/py-3.13-linux-64.conda.lock.yml # environments/py-3.13-win-64-dev.conda.lock.yml # environments/py-3.13-win-64.conda.lock.yml # environments/py-3.14-linux-64-dev.conda.lock.yml # environments/py-3.14-linux-64.conda.lock.yml # environments/py-3.14-win-64-dev.conda.lock.yml # environments/py-3.14-win-64.conda.lock.yml # py-3.12.conda-lock.yml # py-3.13.conda-lock.yml # py-3.14.conda-lock.yml
benk-mira
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2826 - Plate match parallel process fails without good error log