GEOPY-2803: simpeg_group_to_driver cannot retrieve driver class from deprecated inversion type

[domfournier]

GEOPY-2803 - simpeg_group_to_driver cannot retrieve driver class from deprecated inversion type

[benk-mira]

Just a missing docstring.

The base branch was changed.

[Copilot]

Pull request overview

This PR updates driver-class resolution to support newer UI JSONs that specify the driver via run_command (rather than inversion_type), addressing failures when reconstructing drivers from stored SimPEG group options.

Changes:

• Introduces driver_class_from_dict (and relocates driver_class_from_name) into simpeg_drivers.utils.utils and switches call sites to use it.
• Updates simpeg_group_to_driver to use the new dict-based driver resolution.
• Adjusts tests to stop using the removed from_input_file path and to reflect the current on-disk options format.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
simpeg_drivers/utils/utils.py	Adds driver_class_from_dict/driver_class_from_name and routes simpeg_group_to_driver through the new resolution logic.
simpeg_drivers/driver.py	Removes deprecated driver-resolution helpers and uses driver_class_from_dict for the CLI entrypoint.
simpeg_drivers/plate_simulation/options.py	Switches simulation parameter driver resolution to driver_class_from_dict.
simpeg_drivers/plate_simulation/driver.py	Updates import to the new location of driver_class_from_name.
tests/uijson_test.py	Updates UI JSON tests to use driver_class_from_dict instead of from_input_file.
tests/run_tests/driver_joint_pgi_homogeneous_test.py	Modifies test setup to remove inversion_type from stored out_group options.
pyproject.toml	Removes setuptools/setuptools-scm from build-system requirements.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Using del options["inversion_type"] will raise KeyError if the stored options already match the newer JSON format (no inversion_type). Using options.pop("inversion_type", None) keeps the test robust across both option formats.

Suggested change

	del options["inversion_type"]
	options.pop("inversion_type", None)

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.27%. Comparing base (4cfa196) to head (0d38280).
⚠️ Report is 10 commits behind head on release/GA_4.8.

Files with missing lines	Patch %	Lines
simpeg_drivers/utils/utils.py	78.26%	3 Missing and 2 partials ⚠️
simpeg_drivers/driver.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##           release/GA_4.8     #382      +/-   ##
==================================================
+ Coverage           90.22%   90.27%   +0.04%     
==================================================
  Files                 132      132              
  Lines                6484     6475       -9     
  Branches              817      815       -2     
==================================================
- Hits                 5850     5845       -5     
+ Misses                421      420       -1     
+ Partials              213      210       -3     

Files with missing lines	Coverage Δ
simpeg_drivers/plate_simulation/driver.py	92.96% <100.00%> (ø)
simpeg_drivers/plate_simulation/options.py	87.87% <100.00%> (+3.26%)	⬆️
simpeg_drivers/driver.py	87.53% <66.66%> (+0.70%)	⬆️
simpeg_drivers/utils/utils.py	66.77% <78.26%> (+0.42%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.