Skip to content

GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names#380

Merged
domfournier merged 4 commits intorelease/GA_4.8from
GEOPY-1029B
Apr 20, 2026
Merged

GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names#380
domfournier merged 4 commits intorelease/GA_4.8from
GEOPY-1029B

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented Apr 16, 2026

GEOPY-1029 - Add datetime stamp to simpeg.log and simpeg.out file names

Copilot AI review requested due to automatic review settings April 16, 2026 22:56
@github-actions github-actions Bot changed the title GEOPY-1029 GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names Apr 16, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes inversion log artifact filenames (e.g., SimPEG.log) to be deterministic across runs, and updates related tests and directive configuration accordingly.

Changes:

  • Switch inversion logger output from timestamped SimPEG_<timestamp>.log to fixed SimPEG.log (and delete any pre-existing file on start).
  • Update ScaleMisfitMultipliers chi-factor output filename to fixed ChiFactors.log.
  • Update gravity driver test expectations to reference the new fixed filenames.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
simpeg_drivers/driver.py Write logs to SimPEG.log (fixed name), return Path from get_path, and remove any existing log at start.
simpeg_drivers/components/factories/directives_factory.py Change chi-factor log output to ChiFactors.log (fixed name).
tests/run_tests/driver_grav_test.py Update test to read SimPEG.log and assert workspace entities for SimPEG.log / SimPEG.out.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpeg_drivers/driver.py
Comment thread simpeg_drivers/components/factories/directives_factory.py
Comment thread tests/run_tests/driver_grav_test.py
Copy link
Copy Markdown
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on simpeg pr, I think we should be warning

benk-mira
benk-mira previously approved these changes Apr 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.21%. Comparing base (9377954) to head (f14e32c).
⚠️ Report is 5 commits behind head on release/GA_4.8.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/GA_4.8     #380   +/-   ##
===============================================
  Coverage           90.21%   90.21%           
===============================================
  Files                 131      131           
  Lines                6497     6500    +3     
  Branches              809      810    +1     
===============================================
+ Hits                 5861     5864    +3     
  Misses                427      427           
  Partials              209      209           
Files with missing lines Coverage Δ
...drivers/components/factories/directives_factory.py 95.49% <ø> (ø)
simpeg_drivers/driver.py 87.41% <100.00%> (+0.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit 078c1c0 into release/GA_4.8 Apr 20, 2026
18 of 19 checks passed
@domfournier domfournier deleted the GEOPY-1029B branch April 20, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants