Conversation
72efcff to
66df72f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #124 +/- ##
========================================
Coverage 84.74% 84.74%
========================================
Files 18 18
Lines 983 983
Branches 129 129
========================================
Hits 833 833
Misses 112 112
Partials 38 38 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
five small changes please:
- move
[build-system]section at the very top of pyproject.toml - move
requires-poetry = ">=2.0"at the top of the[tool.poetry]section - declare dependencies as dynamic
- revert
.pre-commit-config.yaml - add
poetry checkto pre-commit config. See example in geoh5py: https://github.com/MiraGeoscience/geoh5py/blob/develop/.pre-commit-config.yaml#L14- repo: https://github.com/python-poetry/poetry rev: 2.1.1 hooks: - id: poetry-check args: [--lock]
|
@andrewg-mira, also try relocking with Make sure to use latest version from https://github.com/MiraGeoscience/py-deps-lock |
18c6040 to
a7fa086
Compare
for more information, see https://pre-commit.ci
|
Code Climate has analyzed commit 77544b0 and detected 0 issues on this pull request. View more on Code Climate. |
sebhmg
left a comment
There was a problem hiding this comment.
Please:
- move the
[build-system]section at the top - try adding the poetry-check hook as the first hook in pre-commit
- repo: https://github.com/python-poetry/poetry
rev: 2.1.3
hooks:
- id: poetry-checkit used not to like some constructions for conda-lock, but maybe it will accept them now
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project to use Poetry 2 instead of Poetry 1 and adds pyproject.toml validation through pre-commit hooks. The migration involves reorganizing the pyproject.toml file to use the modern standard project metadata format while maintaining backward compatibility with Poetry's dependency management.
- Updates Poetry configuration to use version 2.x format with PEP 621 standard project metadata
- Migrates version format from
0.6.0-alpha.1to0.6.0a1to comply with PEP 440 - Adds Poetry validation to pre-commit hooks and updates development environment dependencies
Reviewed Changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Restructures configuration for Poetry 2 with PEP 621 project metadata and modern build system |
| tests/version_test.py | Updates version parsing logic and replaces semver validation with PEP 440 validation |
| geoapps_utils/init.py | Updates package version to use PEP 440 compliant format |
| environments/*.conda.lock.yml | Updates conda lock files with newer package versions and dependency hashes |
| .pre-commit-config.yaml | Adds Poetry validation hook to ensure pyproject.toml correctness |
| .github/workflows/python_analysis.yml | Temporarily points to development branch for CI tools |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
DEVOPS-690 - use Poetry 2 and have pyproject.toml checked by pre-commit