GEOPY-2769: optional environment parameter for pixi envs#163
GEOPY-2769: optional environment parameter for pixi envs#163RomFloreani wants to merge 23 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an optional Pixi environment override to the reusable Python workflows to unblock downstream testing (GEOPY-QA) by allowing callers to select a specific Pixi environment name instead of always deriving it from the Python version.
Changes:
- Added a new
pixi-environmentworkflow input to the reusable static analysis and pytest workflows. - Updated Pixi setup usage to pass the optional environment name through to the Pixi setup action (and bumped the referenced action version).
- Extended the composite Pixi setup action to prefer an explicit environment name when provided.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/reusable-python-static_analysis.yml | Adds pixi-environment input and forwards it into Pixi environment setup. |
| .github/workflows/reusable-python-pytest.yml | Adds pixi-environment input and forwards it into Pixi environment setup for matrix runs. |
| .github/actions/reusable-python-setup_pixi/action.yml | Adds environment input and updates env-name selection logic to prefer it over derived name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebhmg
changed the title
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
Please see some suggestions on safety checks and naming
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
see suggestion to limit to pixi tsk and avoid shell injection
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
please see questions and suggestions. Also review feedback from Copilot
|
@copilot apply changes based on the comments in this thread |
- Remove `test-cmd` input (shell injection risk); hardcode default pytest command for conda/poetry/hatch - Make `Validate pixi task` step conditional on pixi-task being set (skip when not provided) - Fall back to default pytest/pylint command when pixi-task not specified - Use `python` instead of `python3` for cross-platform compatibility - Fix pixi-task-args JSON parsing to emit a clear error on invalid input - Pass $FILES_PARAM to custom pixi task in static_analysis modified-files step Agent-Logs-Url: https://github.com/MiraGeoscience/CI-tools/sessions/80178279-2577-46b3-a3cf-d4f46677967f Co-authored-by: RomFloreani <270727719+RomFloreani@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
see if jq can help instead of inline python
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
see some more suggestion to simplify and replace inline python script by jq for task args
GEOPY-2769: add an environment optional parameter for pixi envs
see it in action, fixing GEOPY-QA worklfows at https://github.com/MiraGeoscience/geopy-qa/pull/21