feat: make setters for max_length - #356
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Pringled
approved these changes
Aug 31, 2026
| _UNSET = _UnsetType() | ||
|
|
||
|
|
||
| class StaticModelConfig(TypedDict, total=False): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to set
max_lengthon the model2vec model object itself. When set toNone, truncation is disabled as before. This setting is correctly stored on the model, likenormalize. As before, it is still possible to overridemax_lengthfromencode. When max_length is not specified, we set it to a default of 512. This ensures that old models still have the same behavior.One new feature is that
max_lengthis propagated to the pipeline and the training. These previously both used hardcoded constants of 512 (training) and a similar construct to the mainStaticModel(pipeline). The end result is that users now have a central way to setmax_lengthon their models, and that this setting is respected by all consumers.I also turned the
configwe load into aTypedDict, and had to create a sentinel type to distinguish betweenmax_lengthnot being set and the user disablingmax_length(None)