Repository navigation
Qualify function tools in the Codex and Claude views - #478
Merged
Merged
Conversation
Codex's view declares function tools and function-result images, and keeps tool search unsupported. Claude's view derives function tools, result images and tool search from the probed bridge features with the predicates its workspace Runtime uses, since the view runs the bridge in workspace mode. The agent-host qualification answers each function call through dispatch with a text, image and text result. A view that declares function tools runs a second Turn in a new Executor that resumes the native session and calls the function; a view that declares tool search runs a Turn in another Session that finds the deferred function. Codex keeps its dynamic tools when a new app-server resumes the thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function tools and function-result images are now declared Supported in the Codex view. The Claude view derives function tools, function-result images and tool search from the probed
RuntimeInfo, the same checks its workspace mode uses. Tool search stays Unsupported for Codex, as in its non-view path.The agent-host qualification proves each declaration through dispatch:
lookup_ticket. The test answers with a text, image and text result and checks that the answer reports both texts.Codex keeps its dynamic tools when a new Executor resumes the thread (one
thread/start, both Turns on one thread), so the coverage ledger gains no entry.Real-Harness qualification (
scripts/qualify-agent-host.sh):PASS TestHarnessSessionsAgainstTheSandboxwith claude_sdk (3 Turns), codex (2 Turns, including resume) and mcode, andPASS TestViewCgroupDelegation.Focused tests:
agent/codex,agent/claudesdk,agenthost,agenthostqualify;go vet,gofmt, darwin and windows builds ofapps/daemon,make check-names check-docs check-ci.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.