Repository navigation
Type the Runtime prompt request and delete paths without callers - #471
Merged
Merged
Conversation
Replace PromptRequestPayload.AgentOptions with the four fields Core sends: model, system_prompt, model_provider and harness_config. Core-to-Runtime request payloads, including execution_prepare.configuration, now decode strictly through Envelope.DecodeRequest and reject undeclared members such as agent_options; upstream frames stay lenient. Delete what had no producer: workspace authoring (request flag, capability, state projection, CLI bridge and wire messages), Skill upload, capability downloads and the companion PATH injection, Session/Executor capability contexts, managed Skill downloads, adapter parsing of options nobody sends, and ConnectionOptions. Also delete three dead machine paths: the device_shutdown message (SIGTERM shutdown stays), daemon pairing through /api/v1/runtimes/pair with its --url/--token flow and runtimecrypto, and the gateway DeviceOwnerStore owner lease. The operator device profile written by oac-core-device stays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Core–Runtime prompt request say exactly what Core sends, and deletes every path that had no caller.
Typed request.
PromptRequestPayload.AgentOptions(map[string]any) becomes four typed fields:Model,SystemPrompt,ModelProviderandHarnessConfig. Core never sent any other key.Envelope.DecodeRequest, which rejects unknown keys, includingagent_optionsand anything insideexecution_prepare.configuration. Upstream frames are unchanged.Deleted, each verified to have no producer outside tests:
WorkspaceAuthoring: the flag, the capability, the authoring bridge and its wire messages.SessionCapabilityContext/ExecutorCapabilityContext.mcp_servers,env,plugin_dirs,allowed_tools,mode,skills, …),managedskills, andConnectionOptions.device_shutdown, which Core never sends. SIGTERM shutdown stays./api/v1/runtimes/pair, a route Core doesn't have, plusinternal/runtimecryptoandgolang.org/x/crypto.OwnerStore, which is never set, and its owner-lease types.Kept: native MCP fed by the declared bindings, Environment preparation,
harness_config, and the operator device profile written byoac-core-device.Docs (en + zh):
runtime-protocol.md,runtime-bootstrap.md,harness-onboarding.md,machine-api.md.Net: production −2,357 lines, tests −2,341, docs −3.
Checks:
make check-names check-docs check-ci.-race -count=50on dispatch shutdown.scripts/qualify-agent-host.shpasses for Claude Code, Codex and MiniMax Code.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.