Repository navigation
fix: make installation retries safe and predictable - #470
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
marked this pull request as ready for review
October 7, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installation failures must be safe to retry, including after a killed process. Core now prepares configuration and pulls images before publishing its owned staging directory, preserves published configuration and data, and lets the original command rerun against saved settings. Startup failures include service diagnostics.
Node file writes share one temporary-file lifecycle across downloads, extraction, helpers, configuration and enrollment. Configuration is published atomically so killing a writer cannot leave a partial final file. Interrupted bytes are discarded instead of resumed; complete verified components remain reusable. The generated command checks prerequisites before downloading and separates disposable downloads from verified bootstraps. Native Runtime commands report missing Windows archive tools and Unix execution failures before claiming success.
Validation:
Known limitation: a process killed between generation lease creation and publication of its durable inode identity requires operator inspection. Automatic lease adoption is intentionally outside this change: retaining the current refusal preserves Runtime helper exclusion without adding a second recovery state machine. The installer guide documents this boundary.
Additional validation: SIGKILL during installation.json, provider.json and registered.json writes, followed by successful retries; 16 focused configuration/registration/generation tests passed locally.
Independent review of the complete diff found no blocking issues under the agreed correctness and complexity criteria.