Skip to content

fix: make installation retries safe and predictable - #470

Merged
SaladDay merged 6 commits into
mainfrom
codex/installation-reliability
Oct 7, 2026
Merged

SaladDay merged 6 commits into
mainfrom
codex/installation-reliability

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Installation failures must be safe to retry, including after a killed process. Core now prepares configuration and pulls images before publishing its owned staging directory, preserves published configuration and data, and lets the original command rerun against saved settings. Startup failures include service diagnostics.

Node file writes share one temporary-file lifecycle across downloads, extraction, helpers, configuration and enrollment. Configuration is published atomically so killing a writer cannot leave a partial final file. Interrupted bytes are discarded instead of resumed; complete verified components remain reusable. The generated command checks prerequisites before downloading and separates disposable downloads from verified bootstraps. Native Runtime commands report missing Windows archive tools and Unix execution failures before claiming success.

Validation:

  • Core installer: 20 tests, including SIGKILL, unrelated-directory preservation, concurrent operations, write limits, explicit image pulls, failed startup and retained data.
  • Node artifact transport: 20 tests; 20 focused node lifecycle/helper tests (one root-only test skipped locally).
  • Generated Node command: 15 tests; Web typecheck; affected add/remove Node browser acceptance tests.
  • Native bootstrap suite on macOS arm64; shell syntax, documentation and translation checks.
  • CI passed on the final commit: Linux, macOS and Windows native builds/bootstrap tests, Docker Compose, complete Linux distribution tests, backend/API checks, Web browser acceptance and documentation checks. Local Docker was unavailable.

Known limitation: a process killed between generation lease creation and publication of its durable inode identity requires operator inspection. Automatic lease adoption is intentionally outside this change: retaining the current refusal preserves Runtime helper exclusion without adding a second recovery state machine. The installer guide documents this boundary.

Additional validation: SIGKILL during installation.json, provider.json and registered.json writes, followed by successful retries; 16 focused configuration/registration/generation tests passed locally.

Independent review of the complete diff found no blocking issues under the agreed correctness and complexity criteria.

@blacksmith-sh

This comment has been minimized.

@SaladDay
SaladDay marked this pull request as ready for review October 7, 2026 08:11
@SaladDay
SaladDay merged commit 1618d4e into main Oct 7, 2026
23 checks passed
@SaladDay
SaladDay deleted the codex/installation-reliability branch October 7, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant