Skip x.x.x and TBD placeholder tags in docker image validator#1191
Merged
Skip x.x.x and TBD placeholder tags in docker image validator#1191
Conversation
The validator already skips placeholders wrapped in {}, <>, $, or [],
but docs frequently use literal placeholders like "3.x.x" or "TBD" to
mark a version the reader must substitute (e.g. an unpublished release).
Treat those as placeholders too so the validator does not 404 on tags
that intentionally don't exist yet.
Recognised tag-side patterns (case-insensitive):
- x.x, x.x.x, X.X, X.X.X
- TBD
Concrete tags like 3.0.0 are still validated.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SanabriaRusso
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/validate-docker-images.js) skips placeholders wrapped in{},<>,$, or[], but the docs frequently use bare literals like3.x.xorTBDto mark a version the reader must substitute.hasTemplatePlaceholders:x.x[.x]/X.X[.X]andTBD. Concrete versions like3.0.0are still validated.Test plan
minaprotocol/mina-daemon-auto-hardfork:3.x.x-bullseye-mainnet→ SKIPminaprotocol/mina-daemon-auto-hardfork:3.x.x-noble-mainnet→ SKIPminaprotocol/mina-daemon:3.x.x-bullseye-mainnet→ SKIPminaprotocol/mina-daemon:TBD-bullseye-mainnet→ SKIPminaprotocol/mina-daemon:X.X-bullseye-mainnet→ SKIPminaprotocol/mina-daemon:3.0.0-bullseye-mainnet→ CHECK (still validated)validate-docker-imagesGitHub Actions check stays green on this PR.3.x.x-*) no longer fail validation. Concrete4.0.0-*-mesaexample tags in added initial draft for upgrade to mesa #1133 will still need to be moved to4.x.x(separate change).🤖 Generated with Claude Code