Ticket #5103: fix parse-mode error format mismatch in viewer#5105
Merged
zyv merged 1 commit intoMidnightCommander:masterfrom Apr 27, 2026
Merged
Ticket #5103: fix parse-mode error format mismatch in viewer#5105zyv merged 1 commit intoMidnightCommander:masterfrom
zyv merged 1 commit intoMidnightCommander:masterfrom
Conversation
github-actions
Bot
added
needs triage
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the internal viewer’s parse-mode error handling by aligning the error format string with how mcview_show_error() delegates to file_error_message() (single filename argument).
Changes:
- Update the parse-mode “Cannot open …” error message to use a single
%splaceholder, matching the single filename argument passed throughfile_error_message().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zyv
added
area: mcview
zyv
changed the title
zyv
approved these changes
Apr 27, 2026
Member
zyv
left a comment
zyv
left a comment
There was a problem hiding this comment.
Thank you for finding the root cause 👍
zyv
requested review from
aborodin and
mc-worker
and removed request for
aborodin
azazar
force-pushed
the
master
branch
3 times, most recently
from
64e868c to
f7ff591
Compare
Member
|
Please remove unrelated commit from this PR. |
Fixes MidnightCommander#5103 Signed-off-by: Mikhail Yevchenko <spam@uo1.net>
Author
|
I'm sorry for that mess. |
mc-worker
approved these changes
Apr 27, 2026
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a segfault in viewer parse-mode error handling.
%sarguments, but only one was passed.Fixes #5103.
Relates to #5058.