Revise spell-check API to return read-only suggestions - #5686
Open
Shreya Shree (shreyashree16) wants to merge 6 commits into
Open
Revise spell-check API to return read-only suggestions#5686Shreya Shree (shreyashree16) wants to merge 6 commits into
Shreya Shree (shreyashree16) wants to merge 6 commits into
Conversation
Replace full context-menu items with a dedicated read-only suggestion model while preserving CommandId-based execution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f4e4407d-58d1-4594-8fd3-1e9d2e71cd7f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f4e4407d-58d1-4594-8fd3-1e9d2e71cd7f
Navdeep Singh (Navdeep-ss)
left a comment
Contributor
There was a problem hiding this comment.
Changes looks fine, just some nit comment around not adding implementation details, and removing information which doesn't make sense now, since the api has evolved
added 2 commits
September 4, 2026 14:24
Remove redundant and speculative content, avoid implementation-specific timing details, and clarify suggestion wording. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f4e4407d-58d1-4594-8fd3-1e9d2e71cd7f
Describe how future actions and settings remain additive under the dedicated suggestion-object design. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f4e4407d-58d1-4594-8fd3-1e9d2e71cd7f
Align callback timing and result semantics, document suggestion lifetime, and complete the Win32 selection example. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f4e4407d-58d1-4594-8fd3-1e9d2e71cd7f
|
Shreya Shree (@shreyashree16) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6ec721ff-0b88-4fc7-be52-5700c9597be3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #5553 based on API design feedback.
CoreWebView2ContextMenuItemsuggestion results with a dedicated read-onlyCoreWebView2SpellCheckSuggestiontype.SuggestionTextandCommandIdfor each spelling correction.SelectedCommandIdexecution flow.Motivation
A full context-menu item is mutable and contains properties unrelated to spelling suggestions. A dedicated read-only type makes the API contract clearer and avoids representing future spell-check actions as an untyped collection distinguished by magic names.