Fix 36 instances of broken fwlink to Microsoft.Windows.ServerManager.Migration #4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
See explanation in the opening comment. This PR replaces the fwlink with an updated hardcoded link. Contributor guidance differs on whether fwlinks should be used. If it's decided to update the fwlink instead, someone will need to take ownership then update the link. Thanks! |
Author
|
Closing because fwlink was updated. |
Member
|
After research i found that we could update the fwd link with the correct destination URL. We did that, so we are closing this PR. Updated in the aka.ms site - https://akalinkmanager.trafficmanager.net/am/redirection/home?options=host:go.microsoft.com. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Updates 36 instances of broken fwlink http://go.microsoft.com/fwlink/?LinkId=246313 to /powershell/module/microsoft.windows.servermanager.migration
Per broken links User Story https://dev.azure.com/msft-skilling/Content/_workitems/edit/436781.
PR Checklist
Note that although the broken links spreadsheet states that fwlinks should be updated in the redirection database at https://redirectiontool.trafficmanager.net/am/redirection/home?options=host:go.microsoft.com, the Learn Contributor Guide at https://learn.microsoft.com/en-us/help/platform/links-how-to#fwlinks-and-akams-links conversely states that fwlinks should not be used. (This fwlink does not have an owner in the database so would require at least 2 owners one of which must be FTE plus a group owner to take ownership and then update the link.)