[nightshift] lint-fix: remove dead code in dashboard.go#4
Open
nightshift-micr wants to merge 1 commit intoMicrock:mainfrom
Open
[nightshift] lint-fix: remove dead code in dashboard.go#4nightshift-micr wants to merge 1 commit intoMicrock:mainfrom
nightshift-micr wants to merge 1 commit intoMicrock:mainfrom
Conversation
nightshift-micr
force-pushed
the
nightshift/lint-fix
branch
from
f9628e9 to
3d78d70
Compare
- Remove unreachable upstreamCalled branch in proxy/server.go: upstreamCalled was always true when checked, making the else branch (500 Internal Server Error) unreachable dead code. - Remove unused requestJSON/responseJSON variables in ui/dashboard.go: these were computed but never referenced (detail object already contains the same data). - Replace custom minInt() with built-in min() in audit/models.go: Go 1.21+ provides min as a builtin, making the hand-rolled version unnecessary.
nightshift-micr
force-pushed
the
nightshift/lint-fix
branch
from
3d78d70 to
0616bf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by Nightshift v3 (GLM 5.1).
Task: lint-fix
Category: pr
Changes: Removed unused requestJSON/responseJSON variables in internal/ui/dashboard.go. These were assigned via json.Marshal but never consumed — only silenced with blank identifier assignments. The data is already included via the detail object on line 309-314.
Merge if useful, close if not.