Repository navigation
Fix getPlaceSide causing mis-placements onto replaceable blocks - #6803
Open
Gingerbeard5773 wants to merge 1 commit into
Open
Gingerbeard5773 wants to merge 1 commit into
Gingerbeard5773 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
BlockUtils.getPlaceSide has a minor issue where it will attempt to use a replaceable block as a valid surface to place off of. The result is that whatever code was using getPlaceSide, ends in the block getting placed onto the replaceable block rather than the intended position.
Real example of the bug in practice:
Anchor aura attempts to place an anchor but theres a fire next to the intended target blockpos. It ends up placing onto the neighboring fire, causing the anchor to be misplaced.
This PR fixes this issue
Related issues
N/A
Checklist: