Refactor launcher into source set, eliminate launch subproject #5992
+51
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Refactor launcher into source set, eliminate
launchsubprojectMoves the Java 8 launcher from a separate subproject into a dedicated source set within the main build.
This is based on the design used by Iris, which has many subprojects/sourcesets.
The separate launch subproject caused issues with Loom's
migrateMappingstask,which expected a single-project structure and would fail to properly remap sources when a multi-project setup was present.
Related issues
None.
How Has This Been Tested?
Running the JAR via Java 8 to test popup, loading in Prism Laauncher via Java 21 to test mod initialization.
Checklist: