fix: start Community Prediction at question open_time#4688
fix: start Community Prediction at question open_time#4688SylvainChevalier wants to merge 2 commits intomainfrom
Conversation
Pre-predictions made before the question opens were being included in the CP timeline, causing it to start before open_time. Now clip pre-open forecasts so the CP timeline begins at the question's open_time, while still incorporating the most recent pre-open forecast state from each user that is still active at open_time. Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@lsabor feel free to throw away if bad. |
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
|
@claude please fix the issues revealed by the unit tests. |
|
Claude finished @SylvainChevalier's task in 5m 38s —— View job CI fix pushed
SummaryThe "unit tests" CI run was failing only because of the The two new if (
earliest_time
and forecast.end_time
and forecast.end_time <= earliest_time
):Once collapsed they fit on a single 86-char line (under the project's 88 limit), which is the form ruff/Black enforce. Both occurrences (in
|
Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
Pre-predictions made before the question opens were being included in the CP timeline, causing it to start before open_time. Now clip pre-open forecasts so the CP timeline begins at the question's open_time, while still incorporating the most recent pre-open forecast state from each user that is still active at open_time.