feat: Restrict @predictors mentions to curators/admins with warning toast#4599
Draft
SylvainChevalier wants to merge 1 commit intomainfrom
Draft
feat: Restrict @predictors mentions to curators/admins with warning toast#4599SylvainChevalier wants to merge 1 commit intomainfrom
SylvainChevalier wants to merge 1 commit intomainfrom
Conversation
- Backend: filter @predictors to only active (non-withdrawn) predictions by excluding forecasts with end_time in the past - Frontend: show warning toast when non-admin/curator uses @predictors in both comment creation and editing flows - Frontend: add mention autocomplete with permission filtering to the comment edit form (was previously only on new comment form) - Add translation key for the warning message - Add test for withdrawn forecast exclusion Fixes #4082 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
SylvainChevalier
had a problem deploying
to
testing_env
GitHub Actions
Failure
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
Contributor
Author
|
@claude please fix the unit test problems. |
Contributor
|
Claude encountered an error —— View job Fixing Unit Test Problems
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@predictorsautocomplete suggestion only shown to curators/admins (already existed)@predictorsFixes #4082
Generated with Claude Code