Skip to content

fix: Allow scroll passthrough on tweet embeds#4503

Draft
SylvainChevalier wants to merge 3 commits intomainfrom
claude/issue-4455-tweet-embeds-make-scrolling-difficult
Draft

fix: Allow scroll passthrough on tweet embeds#4503
SylvainChevalier wants to merge 3 commits intomainfrom
claude/issue-4455-tweet-embeds-make-scrolling-difficult

Conversation

@SylvainChevalier
Copy link
Copy Markdown
Contributor

Removes overscroll-behavior: contain from tweet embed scroll containers so that when a tweet is scrolled to its boundary, the scroll propagates to the page. This improves scrolling UX especially on mobile.

Closes #4455

Generated with Claude Code

Allow scroll to propagate to the page when a tweet embed is scrolled
to the top or bottom, improving scrolling UX especially on mobile.

Closes #4455

Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c005dd5d-beb3-4361-9f75-316ce2de6e54

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-4455-tweet-embeds-make-scrolling-difficult

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

🚀 Preview Environment

Your preview environment is ready!

Resource Details
🌐 Preview URL https://metaculus-pr-4503-claude-issue-4455-tweet-embeds-preview.mtcl.cc
📦 Docker Image ghcr.io/metaculus/metaculus:claude-issue-4455-tweet-embeds-make-scrolling-difficult-35be7fe
🗄️ PostgreSQL NeonDB branch preview/pr-4503-claude-issue-4455-tweet-embeds
Redis Fly Redis mtc-redis-pr-4503-claude-issue-4455-tweet-embeds

Details

  • Commit: 35be7febe6db26018a25c0d092d61f408d4f31fa
  • Branch: claude/issue-4455-tweet-embeds-make-scrolling-difficult
  • Fly App: metaculus-pr-4503-claude-issue-4455-tweet-embeds

ℹ️ Preview Environment Info

Isolation:

  • PostgreSQL and Redis are fully isolated from production
  • Each PR gets its own database branch and Redis instance
  • Changes pushed to this PR will trigger a new deployment

Limitations:

  • Background workers and cron jobs are not deployed in preview environments
  • If you need to test background jobs, use Heroku staging environments

Cleanup:

  • This preview will be automatically destroyed when the PR is closed

@SylvainChevalier
Copy link
Copy Markdown
Contributor Author

@claude the Preview Environment seems to be erroring out.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 8, 2026

Claude finished @SylvainChevalier's task in 1m 7s —— View job


Investigating Preview Environment Issue

  • Gather context on the PR and preview environment
  • Check CI/deployment status and logs
  • Investigate the error and report findings

Findings

All CI jobs passed (unit tests, integration tests, preview deployment), but the deploy logs reveal the root cause. During the Fly.io deployment, this warning was emitted:

WARNING The app is not listening on the expected address and will not be reachable by fly-proxy.
You can fix this by configuring your app to listen on the following addresses:
  - 0.0.0.0:8080
Found these processes inside the machine with open listening sockets:
  PROCESS        | ADDRESSES                              
-----------------*----------------------------------------
  /.fly/hallpass | [fdaa:3e:ce03:a7b:60d:7a39:688c:2]:22  

This means the Fly machine was created and started, but the application process is not binding to port 8080 as expected by Fly's proxy. Only the SSH hallpass process is listening — the actual web server never started or crashed on startup.

This is not related to the PR's code change (which only removes one CSS line). It's an infrastructure/preview environment issue — likely the app is failing during startup inside the container. Unfortunately, I don't have access to the Fly.io runtime logs (flyctl logs) from this environment to see the exact startup error.

Suggestions

  1. Check Fly runtime logs — someone with Fly access can run:

    flyctl logs -a metaculus-pr-4503-claude-issue-4455-tweet-embeds
    

    to see why the app process isn't starting.

  2. Try redeploying — push an empty commit or re-run the preview workflow to see if it's a transient issue.

  3. Check if other PR previews work — if they're also broken, it could be a broader infrastructure issue.


| Branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tweet embeds make scrolling difficult on mobile

1 participant