fix: Allow scroll passthrough on tweet embeds#4503
fix: Allow scroll passthrough on tweet embeds#4503SylvainChevalier wants to merge 3 commits intomainfrom
Conversation
Allow scroll to propagate to the page when a tweet embed is scrolled to the top or bottom, improving scrolling UX especially on mobile. Closes #4455 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
|
@claude the Preview Environment seems to be erroring out. |
|
Claude finished @SylvainChevalier's task in 1m 7s —— View job Investigating Preview Environment Issue
FindingsAll CI jobs passed (unit tests, integration tests, preview deployment), but the deploy logs reveal the root cause. During the Fly.io deployment, this warning was emitted: This means the Fly machine was created and started, but the application process is not binding to port 8080 as expected by Fly's proxy. Only the SSH hallpass process is listening — the actual web server never started or crashed on startup. This is not related to the PR's code change (which only removes one CSS line). It's an infrastructure/preview environment issue — likely the app is failing during startup inside the container. Unfortunately, I don't have access to the Fly.io runtime logs ( Suggestions
| Branch |
Removes
overscroll-behavior: containfrom tweet embed scroll containers so that when a tweet is scrolled to its boundary, the scroll propagates to the page. This improves scrolling UX especially on mobile.Closes #4455
Generated with Claude Code