Skip to content
This repository was archived by the owner on Sep 11, 2026. It is now read-only.

chore: remove uuid dependency - #289

Open
gameroman wants to merge 2 commits into
MetaMask:mainfrom
gameroman:remove-uuid
Open

chore: remove uuid dependency#289
gameroman wants to merge 2 commits into
MetaMask:mainfrom
gameroman:remove-uuid

Conversation

@gameroman

@gameroman gameroman commented May 27, 2026

Copy link
Copy Markdown

Note

Low Risk
Small dependency swap in test-only sandbox naming; supported by the package’s Node engine range (^18.18+).

Overview
Drops the uuid package (and @types/uuid) and uses Node’s built-in crypto.randomUUID() for temporary test sandbox directory names in createSandbox (src/fs.ts).

fs.test.ts mocks crypto.randomUUID instead of uuid.v4 so sandbox path behavior stays deterministic in tests.

Reviewed by Cursor Bugbot for commit 0322fca. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/fs.test.ts Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 1f26227. Configure here.

Comment thread package.json
@cryptodev-2s

Copy link
Copy Markdown
Contributor

This library has now been migrated into the core monorepo. This PR has been locked and this repo will be archived shortly. Going forward, releases of this library will only include changes made in the core repo.

  • Please push this branch to core and open a new PR there.
  • Optionally, add a link pointing to the discussion in this PR to provide context.

Tracked in MetaMask/core#10210.

@MetaMask MetaMask locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants