fix: Add checkForPotentialDuplicates method for tx validation#514
Draft
httpJunkie wants to merge 1 commit intomainfrom
Draft
fix: Add checkForPotentialDuplicates method for tx validation#514httpJunkie wants to merge 1 commit intomainfrom
httpJunkie wants to merge 1 commit intomainfrom
Conversation
…ction validation This change adds a new public method to the SmartTransactionsController that checks if a transaction would likely fail by: 1. Checking for pending transactions with matching parameters 2. Simulating the transaction to detect potential reverts 3. Extracting user-friendly error messages from revert reasons The method is designed to prevent duplicate or failing transactions from being submitted to the blockchain and works in conjunction with changes to the MetaMask extension's SmartTransactionHook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new public method to the SmartTransactionsController that checks if a transaction would likely fail by:
The method is designed to prevent duplicate or failing transactions from being submitted to the blockchain and works in conjunction with changes to the MetaMask extension's SmartTransactionHook.