generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 5
test(kernel-language-model-service): Add queue language model service for testing #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
rekmarks
reviewed
Dec 17, 2025
Member
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits.
43ff5aa to
5080e53
Compare
rekmarks
approved these changes
Dec 17, 2025
Member
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a queue language model service to the monorepo. The implementation is intended for mocking language model behavior where a remote API or local model execution are both unavailable. The intended streaming response is pushed to the model prior to sampling.
Also adds tests to kernel-test which exercise the basic shape of a LanguageModelService.
Note
Adds a queue-based LanguageModelService testing utility and integrates it into kernel tests via new vats, plus updates exports and coverage thresholds.
packages/kernel-language-model-service):src/test-utils/queue/*) withmakeQueueModel,makeQueueService,whitespaceTokenizer,objectResponseFormatter, and streaming helpers (normalizeToAsyncIterable,mapAsyncIterable,makeAbortableAsyncIterable,makeEmptyStreamWithAbort)../test-utilsentry inpackage.jsonand re-export fromsrc/test-utils/index.ts.packages/kernel-test):vats/lms-queue-vat.js(envatted queue service) andvats/lms-user-vat.js(consumer).src/lms-user.test.tsasserting streamed response logging; add dependency on@ocap/kernel-language-model-service.vitest.config.tscoverage thresholds forpackages/kernel-language-model-service/**.Written by Cursor Bugbot for commit 9277005. This will update automatically on new commits. Configure here.