Skip to content

feat(tron-wallet-snap): remove assets migration feature-flag routing #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ulissesferreira wants to merge 3 commits into
base: ulissesferreira/wpn-1497-core-adapter-routing-9863
Choose a base branch
from
Draft

feat(tron-wallet-snap): remove assets migration feature-flag routing #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b817ca2
feat(tron-wallet-snap): remove assets migration feature-flag routing
cursoragent Aug 5, 2026
7201d8d
fix(tron-wallet-snap): remove unused fungible extractors from SnapAss…
cursoragent Aug 5, 2026
64f08a9
fix(tron-wallet-snap): sync CI shasum after extractor cleanup
cursoragent Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/tron-wallet-snap/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add Core messenger plumbing (`getMessenger`, `RemoteFeatureFlagsProvider`, `AssetsProvider`) for upcoming AssetsController migration ([#95](https://github.com/MetaMask/internal-snaps/pull/95))
- Route fungible asset reads through Core AssetsController based on migration stage ([#127](https://github.com/MetaMask/internal-snaps/pull/127))

### Removed

- Assets migration feature-flag routing. Fungible reads (`getAccountAssetByID`, `getAccountAssetsByIDs`, `getAccountAssetsByScope`) now always use Core `AssetsController` via `AssetsProvider`; snap-owned protocol assets remain on the Snap adapter for sync, reads, and keyring events. Removed `RemoteFeatureFlagController:getState` messenger endowment ([#97](https://github.com/MetaMask/internal-snaps/pull/97))

## [3.0.0]

### Added
Expand Down
1 change: 0 additions & 1 deletion packages/tron-wallet-snap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
"@metamask/keyring-api": "^23.7.0",
"@metamask/keyring-snap-sdk": "^9.2.1",
"@metamask/messenger": "^2.0.0",
"@metamask/remote-feature-flag-controller": "^5.0.0",
"@metamask/snap-networks-utils": "^1.0.0",
"@metamask/snaps-cli": "^8.4.1",
"@metamask/snaps-jest": "^10.2.0",
Expand Down
5 changes: 2 additions & 3 deletions packages/tron-wallet-snap/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/internal-snaps.git"
},
"source": {
"shasum": "7nTrlZaA1AUK1SwS66buFFwKxs4nZJG4xWzj49NPkIk=",
"shasum": "6dgldMOKKiG/d+FsXzdI0Smd3MfJn7MCqhykDVXeRf8=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down Expand Up @@ -68,8 +68,7 @@
"actions": [
"AssetsController:getAccountAssetByID",
"AssetsController:getAccountAssetsByIDs",
"AssetsController:getAccountAssetsByScope",
"RemoteFeatureFlagController:getState"
"AssetsController:getAccountAssetsByScope"
]
}
},
Expand Down
18 changes: 3 additions & 15 deletions packages/tron-wallet-snap/src/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
import {
AssetsProvider,
RemoteFeatureFlagsProvider,
} from '@metamask/snap-networks-utils';
import type {
AssetsProviderMessenger,
RemoteFeatureFlagsProviderMessenger,
} from '@metamask/snap-networks-utils';
import { AssetsProvider } from '@metamask/snap-networks-utils';
import type { AssetsProviderMessenger } from '@metamask/snap-networks-utils';
import { getMessenger } from '@metamask/snaps-sdk';

import { InMemoryCache } from './caching/InMemoryCache';
Expand Down Expand Up @@ -100,9 +94,6 @@ const tokenApiClient = new TokenApiClient(configProvider);
* Core controllers plumbing
*/
const coreMessenger = getMessenger<CoreMessengerMessenger>();
const remoteFeatureFlagsProvider = new RemoteFeatureFlagsProvider({
messenger: coreMessenger as RemoteFeatureFlagsProviderMessenger,
});
const assetsProvider = new AssetsProvider({
messenger: coreMessenger as AssetsProviderMessenger,
});
Expand All @@ -123,7 +114,6 @@ const assetsService = new AssetsService({
priceApiClient,
tokenApiClient,
snapClient,
coreMessenger,
assetsProvider,
});

Expand Down Expand Up @@ -263,10 +253,9 @@ export type SnapExecutionContext = {
transactionScanService: TransactionScanService;
transactionExpirationRefresherService: TransactionExpirationRefresherService;
/**
* Core messenger plumbing (routing wired in a follow-up PR).
* Core messenger plumbing for AssetsController reads.
*/
coreMessenger: CoreMessenger;
remoteFeatureFlagsProvider: RemoteFeatureFlagsProvider;
assetsProvider: AssetsProvider;
/**
* Handlers
Expand Down Expand Up @@ -301,7 +290,6 @@ const snapContext: SnapExecutionContext = {
transactionScanService,
transactionExpirationRefresherService,
coreMessenger,
remoteFeatureFlagsProvider,
assetsProvider,
/**
* Handlers
Expand Down
Loading
Loading