Skip to content

Release/5.0.0 - #119

Merged
ulissesferreira merged 9 commits into
mainfrom
release/5.0.0
Aug 5, 2026
Merged

Release/5.0.0#119
ulissesferreira merged 9 commits into
mainfrom
release/5.0.0

Conversation

@ulissesferreira

@ulissesferreira ulissesferreira commented Aug 5, 2026 •
edited by taran-a
Loading

Copy link
Copy Markdown
Contributor

Explanation

This release publishes accumulated changes across the three first-party wallet snaps since their last releases.

Monorepo 4.0.0 → 5.0.0

Package Version Bump
@metamask/bitcoin-wallet-snap 2.0.0 → 2.0.1 patch
@metamask/solana-wallet-snap 4.0.0 → 5.0.0 major
@metamask/tron-wallet-snap 2.0.0 → 3.0.0 major

@metamask/bitcoin-wallet-snap@2.0.1

  • Fix onKeyringRequest responses to return Json directly (Keyring API v2 protocol) instead of the v1 { pending: false, result } envelope (#100)

@metamask/solana-wallet-snap@5.0.0

  • BREAKING: Re-licensed split into LICENSE.MIT or LICENSE.APACHE2 files (SPDX expression unchanged) (#72)
  • This package was migrated from snap-solana-wallet. See the source repository for the original changelog. (#72)

@metamask/tron-wallet-snap@3.0.0

  • BREAKING: Implement Keyring API v2 (KeyringSnapRpc interface): rename listAccounts → getAccounts, listAccountAssets → getAccountAssets, listAccountTransactions → getAccountTransactions; getAccount now throws instead of returning undefined; add exportAccount with hexadecimal private key export; remove v1-only methods (#56)
  • Add bip44:discover support and keyring manifest capabilities (#56)
  • Fix bip44:discover failing due to bidirectional Network enum compilation (#101)
  • Fix submitRequest returning a v1 KeyringResponse envelope instead of raw Json (#105)
  • Disclose the mandatory 9,999 TRX WitnessCreateContract account-upgrade burn on confirmation (#73)

This PR also adds .worktrees/ to .gitignore to prevent local git worktrees from being accidentally committed.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@ulissesferreira
ulissesferreira requested review from a team as code owners August 5, 2026 10:44
@ulissesferreira
ulissesferreira marked this pull request as draft August 5, 2026 10:44
@metamask-ci

This comment has been minimized.

Sign in to view
@ulissesferreira
Remove accidentally committed worktree gitlinks from release branch.
9d1ee2b 
Add .worktrees/ to .gitignore to prevent local worktrees from being tracked.
@ulissesferreira
Update CHANGELOG.md
cf2eb23
@ulissesferreira
Refactor changelog for version 3.0.0
3a22de9 
Removed uncategorized section and refactored changelog entries for clarity.
@ulissesferreira
Update CHANGELOG.md
3b4d6fc
@ulissesferreira
ulissesferreira marked this pull request as ready for review August 5, 2026 11:04
@metamask-ci

metamask-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

✅ No changelog changes needed.

@ulissesferreira
ulissesferreira force-pushed the release/5.0.0 branch 2 times, most recently from dd9e3b6 to 42fc036 Compare August 5, 2026 12:24
jeremytsng pushed a commit that referenced this pull request Aug 5, 2026
@stanleyyconsensys
refactor: error handle batch 1 - add generic error class and implemen…
2ed3884 
…t in networkService (#119)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them
@cursoragent @ulissesferreira
chore: update snap manifests for 5.0.0 release
5a8e076 
Update snap.manifest.json version and shasum fields for all three
wallet snaps to match the bumped package versions.

Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
@ulissesferreira

ulissesferreira commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@MetaMask MetaMask deleted a comment from cursor Bot Aug 5, 2026
@MetaMask MetaMask deleted a comment from cursor Bot Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions. 
@metamask-previews/bitcoin-wallet-snap@2.0.1-preview-5a8e076
@metamask-previews/snap-networks-utils@1.0.0-preview-5a8e076
@metamask-previews/solana-wallet-snap@5.0.0-preview-5a8e076
@metamask-previews/tron-wallet-snap@3.0.0-preview-5a8e076

gabrieledm
gabrieledm reviewed Aug 5, 2026
View reviewed changes
Comment thread packages/tron-wallet-snap/CHANGELOG.md
### Added

- **BREAKING** Implement Keyring API v2 (`KeyringSnapRpc` interface): rename `listAccounts` → `getAccounts`, `listAccountAssets` → `getAccountAssets`, `listAccountTransactions` → `getAccountTransactions`; `getAccount` now throws instead of returning `undefined`; add `exportAccount` with hexadecimal private key export using `sensitive()` for redaction; remove v1-only methods `createAccount`, `discoverAccounts`, `filterAccountChains`, and `updateAccount`. ([#56](https://github.com/MetaMask/internal-snaps/pull/56))
- Add `bip44:discover` support to `createAccounts`: checks on-chain activity across all Tron networks before persisting; returns `[]` if no activity to signal end-of-discovery to the client. ([#56](https://github.com/MetaMask/internal-snaps/pull/56))

@gabrieledm gabrieledm Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason why this line has been removed ?

@ulissesferreira ulissesferreira Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we felt these changes were all part of the implementation of Keyring v2 so even though they had multiple PRs, for whoever is installing this package, all of it will happen at the same time under one big implementation

@taran-a

taran-a commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Tested Solana preview build with the extension.

accounts addresses - ok
add account - ok
add wallet - ok
send sol - ok
swaps - ok
swaps via https://jup.ag/ dapp - ok

ccharly
ccharly reviewed Aug 5, 2026
View reviewed changes
Comment thread packages/tron-wallet-snap/CHANGELOG.md Outdated
- **BREAKING** Implement Keyring API v2 (`KeyringSnapRpc` interface): rename `listAccounts` → `getAccounts`, `listAccountAssets` → `getAccountAssets`, `listAccountTransactions` → `getAccountTransactions`; `getAccount` now throws instead of returning `undefined`; add `exportAccount` with hexadecimal private key export using `sensitive()` for redaction; remove v1-only methods `createAccount`, `discoverAccounts`, `filterAccountChains`, and `updateAccount`. ([#56](https://github.com/MetaMask/internal-snaps/pull/56))
- Add `bip44:discover` support to `createAccounts`: checks on-chain activity across all Tron networks before persisting; returns `[]` if no activity to signal end-of-discovery to the client. ([#56](https://github.com/MetaMask/internal-snaps/pull/56))
- Add `endowment:keyring` capabilities to manifest declaring the `tron:728126428` scope, hexadecimal private key export, and BIP-44 derivation strategies. ([#56](https://github.com/MetaMask/internal-snaps/pull/56))
- **BREAKING** Implement Keyring API v2 (`KeyringSnapRpc` interface) ([#56](https://github.com/MetaMask/internal-snaps/pull/56))

@ccharly ccharly Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes should also be mentionned here IMO:

Suggested change
- **BREAKING** Implement Keyring API v2 (`KeyringSnapRpc` interface) ([#56](https://github.com/MetaMask/internal-snaps/pull/56))
- **BREAKING** Implement Keyring API v2 (`KeyringSnapRpc` interface) ([#56](https://github.com/MetaMask/internal-snaps/pull/56), [#101](https://github.com/MetaMask/internal-snaps/pull/101), [#105](https://github.com/MetaMask/internal-snaps/pull/105))

Comment thread .gitignore

@ccharly ccharly Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: but I feel like this should not be committed alongside a release 😅

@ulissesferreira

ulissesferreira commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@cursoragent implement ccharly's comments

@cursor

cursor Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Implemented both of ccharly's review comments in commit 589dcae3:

  1. Tron changelog — Added PR references for the Keyring API v2 fixes:

    - **BREAKING** Implement Keyring API v2 (`KeyringSnapRpc` interface) ([#56], [#101], [#105])

  2. .gitignore — Removed the .worktrees/ entry so it can land in a separate PR instead of this release.

CI is green on the updated commit. The .worktrees/ gitignore change can be opened as its own follow-up PR whenever you're ready.

Open in Web Open in Cursor 

@cursoragent @ulissesferreira
chore: address review feedback on release PR
589dcae 
- Add PR references for Keyring API v2 fixes to tron changelog
- Remove .worktrees/ gitignore entry (to land in a separate PR)

Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
@ulissesferreira
ulissesferreira added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit d1a7db2 Aug 5, 2026
49 checks passed
@ulissesferreira
ulissesferreira deleted the release/5.0.0 branch August 5, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrieledm gabrieledm gabrieledm left review comments
@ccharly ccharly ccharly approved these changes
@taran-a taran-a taran-a approved these changes
@hmalik88 hmalik88 hmalik88 approved these changes

Assignees

No one assigned

Labels

no-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ulissesferreira @taran-a @ccharly @gabrieledm @hmalik88 @cursoragent