fix: evaluated positive or negative balanceDiff to put transactions in from or to - #108
Open
gabrieledm wants to merge 9 commits into
Conversation
balanceDiff to put transactions in from or to
Base automatically changed from
chore/solana-wallet-snap-integrate-packages
to
main
August 4, 2026 16:11
… in 'from' or 'to'
gabrieledm
force-pushed
the
fix/WPN-1223_solana-incorrect-event-logged-for-swap-operation-from-usdc-to-sol
branch
from
August 4, 2026 20:10
b8e5575 to
70d0971
Compare
…or-swap-operation-from-usdc-to-sol
ulissesferreira
previously approved these changes
Aug 5, 2026
…or-swap-operation-from-usdc-to-sol
jeremytsng
pushed a commit
that referenced
this pull request
Aug 5, 2026
## Explanation This PR refactors synchronization so SEP-41 asset metadata is loaded once per sync run and passed into downstream account/transaction sync services, and introduces a dedicated cronjob to periodically synchronize the asset catalog. <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
ulissesferreira
previously approved these changes
Aug 5, 2026
…or-swap-operation-from-usdc-to-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes incorrect transaction direction and type detection when the fee payer receives an amount of SOL that is less than or equal to the transaction fee.
Previously, native transfer direction was determined using the raw pre and post transaction balances.
For a USDC-to-SOL swap, the fee payer’s balance can still decrease when the received SOL is smaller than the fee.
This caused the incoming SOL to be classified as outgoing and could prevent the transaction from being identified as a swap.
The mapper now determines direction from the fee-adjusted balance difference:
References
Fixes MetaMask/metamask-extension#43164
Changes
Testing
Before
WPN-1223.Before.mov
After
WPN-1223.After.mp4
Checklist