-
-
Notifications
You must be signed in to change notification settings - Fork 308
Update BaseDataService to accommodate mutations, not just queries #9324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcmire
wants to merge
36
commits into
main
Choose a base branch
from
add-execute-mutation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
eb74071
Update BaseDataService to accommodate mutations, not just queries
mcmire ea44597
Add missing comment
mcmire 00baf1c
Remove 100% test coverage
mcmire 237d9f1
Use correct log namespace
mcmire 965c767
Trying to fix this test
mcmire 0676e8f
Explicitly migrate mutations
mcmire 7bd8a6a
Fix JSDoc, function name
mcmire 2a20d8b
Ensure hydrateMutations notifies the mutation cache with the right mu…
mcmire cbc2795
Restore 'istanbul ignore' lines
mcmire 1366d7f
Add createDataDeletionTask to ExampleDataService messenger
mcmire 49f169f
Use TDataStruct, not TStruct, for consistency with fetch(Infinite)Query
mcmire 4ef544e
Adjust type parameters to more closely match TanStack Query
mcmire ba70f30
Add useMutation wrapper
mcmire 35836ff
Clarify comment explaining use of circuit breaker policy alone
mcmire 24a2038
Add 'objectType' to :cacheUpdated event payloads
mcmire 5ddfe6e
Fix comment with missing word
mcmire f07ef66
Export useMutation
mcmire 5bae879
Fully revert 'istanbul ignore' lines
mcmire e2b7230
Wrap comment
mcmire 10b5928
Simplify check in mutation cache subscription handler
mcmire 9539ca9
Remove extraneous comments
mcmire 2473a50
Refactor the conditional into processMutationResponse
mcmire be2b8bf
Correlate UI and service mutations with a globalId
mcmire bc73f72
Extract hydrateMutations into its own file and test it directly
mcmire b7639a8
Clean up
mcmire 80dc628
Clean up 2
mcmire 6381ab9
Clean up 3
mcmire b0c3b8d
Use Struct<TMutationFnData> instead of Struct<any>
mcmire 4e37555
Add a caveat about setQueryData
mcmire cd6be1f
Mint mutation globalId once per built mutation
mcmire fe79ca0
Merge branch 'main' into add-execute-mutation
mcmire 6018bb5
Only sync 'updated' cache events to UI mutations
mcmire 17dcc25
Fix assert
mcmire 5eb3b29
Merge branch 'main' into add-execute-mutation
mcmire 09b7d0f
Update changelog
mcmire ac8209b
Bump uuid to 9.0.1
mcmire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have tests for when the messenger does not have
captureExceptionset. Attaining 100% test coverage seemed out of scope here.