Skip to content

feat: add aligned status tracking to MultichainAccountGroup #9200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gantunesr wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add aligned status tracking to MultichainAccountGroup #9200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4db237
chore: add performance logs
gantunesr Jun 18, 2026
bd3773f
feat: add aligned status tracking to MultichainAccountGroup
gantunesr Jun 19, 2026
a6b37d6
Revert "chore: add performance logs"
gantunesr Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 129 additions & 26 deletions packages/multichain-account-service/src/MultichainAccountGroup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
} from './tests';
import type { MultichainAccountServiceMessenger } from './types';

function setup({
async function setup({
groupIndex = 0,
messenger = getRootMessenger(),
accounts = [
Expand All @@ -41,12 +41,12 @@ function setup({
groupIndex?: number;
messenger?: RootMessenger;
accounts?: InternalAccount[][];
} = {}): {
} = {}): Promise<{
wallet: MultichainAccountWallet<Bip44Account<InternalAccount>>;
group: MultichainAccountGroup<Bip44Account<InternalAccount>>;
providers: MockAccountProvider[];
messenger: MultichainAccountServiceMessenger;
} {
}> {
const providers = accounts.map((providerAccounts, idx) => {
return setupBip44AccountProvider({
name: `Provider ${idx + 1}`,
Expand Down Expand Up @@ -79,7 +79,7 @@ function setup({
return state;
}, {});

group.init(groupState);
await group.init(groupState);

return { wallet, group, providers, messenger: serviceMessenger };
}
Expand All @@ -92,7 +92,7 @@ describe('MultichainAccountGroup', () => {
[MOCK_WALLET_1_SOL_ACCOUNT],
];
const groupIndex = 0;
const { wallet, group } = setup({ groupIndex, accounts });
const { wallet, group } = await setup({ groupIndex, accounts });

const expectedWalletId = toMultichainAccountWalletId(
wallet.entropySource,
Expand All @@ -115,7 +115,7 @@ describe('MultichainAccountGroup', () => {

it('constructs a multichain account group for a specific index', async () => {
const groupIndex = 2;
const { group } = setup({ groupIndex });
const { group } = await setup({ groupIndex });

expect(group.groupIndex).toBe(groupIndex);
});
Expand All @@ -125,36 +125,36 @@ describe('MultichainAccountGroup', () => {
it('gets internal account from its id', async () => {
const evmAccount = MOCK_WALLET_1_EVM_ACCOUNT;
const solAccount = MOCK_WALLET_1_SOL_ACCOUNT;
const { group } = setup({ accounts: [[evmAccount], [solAccount]] });
const { group } = await setup({ accounts: [[evmAccount], [solAccount]] });

expect(group.getAccount(evmAccount.id)).toBe(evmAccount);
expect(group.getAccount(solAccount.id)).toBe(solAccount);
});

it('returns undefined if the account ID does not belong to the multichain account group', async () => {
const { group } = setup();
const { group } = await setup();

expect(group.getAccount('unknown-id')).toBeUndefined();
});
});

describe('get', () => {
it('gets one account using a selector', () => {
const { group } = setup({ accounts: [[MOCK_WALLET_1_EVM_ACCOUNT]] });
it('gets one account using a selector', async () => {
const { group } = await setup({ accounts: [[MOCK_WALLET_1_EVM_ACCOUNT]] });

expect(group.get({ scopes: [EthScope.Mainnet] })).toBe(
MOCK_WALLET_1_EVM_ACCOUNT,
);
});

it('gets no account if selector did not match', () => {
const { group } = setup({ accounts: [[MOCK_WALLET_1_EVM_ACCOUNT]] });
it('gets no account if selector did not match', async () => {
const { group } = await setup({ accounts: [[MOCK_WALLET_1_EVM_ACCOUNT]] });

expect(group.get({ scopes: [SolScope.Mainnet] })).toBeUndefined();
});

it('throws if too many accounts are matching selector', () => {
const { group } = setup({
it('throws if too many accounts are matching selector', async () => {
const { group } = await setup({
accounts: [[MOCK_WALLET_1_EVM_ACCOUNT, MOCK_WALLET_1_EVM_ACCOUNT]],
});

Expand All @@ -165,32 +165,135 @@ describe('MultichainAccountGroup', () => {
});

describe('select', () => {
it('selects accounts using a selector', () => {
const { group } = setup();
it('selects accounts using a selector', async () => {
const { group } = await setup();

expect(group.select({ scopes: [EthScope.Mainnet] })).toStrictEqual([
MOCK_WALLET_1_EVM_ACCOUNT,
]);
});

it('selects no account if selector did not match', () => {
const { group } = setup({ accounts: [[MOCK_WALLET_1_EVM_ACCOUNT]] });
it('selects no account if selector did not match', async () => {
const { group } = await setup({ accounts: [[MOCK_WALLET_1_EVM_ACCOUNT]] });

expect(group.select({ scopes: [SolScope.Mainnet] })).toStrictEqual([]);
});
});

describe('status', () => {
it('is aligned when every provider has at least one account in the group', async () => {
const { group } = await setup({
accounts: [[MOCK_WALLET_1_EVM_ACCOUNT], [MOCK_WALLET_1_SOL_ACCOUNT]],
});

expect(group.status).toBe('aligned');
});

it('is missing-accounts when at least one provider has no accounts in the group', async () => {
const { group } = await setup({
accounts: [
[MOCK_WALLET_1_EVM_ACCOUNT],
[], // second provider has no accounts for this group
],
});

expect(group.status).toBe('missing-accounts');
});

it('does not publish a status change event during init', async () => {
const messenger = getRootMessenger();
const mockStatusChange = jest.fn();
messenger.subscribe(
'MultichainAccountService:multichainAccountGroupStatusChange',
mockStatusChange,
);

await setup({ messenger });

expect(mockStatusChange).not.toHaveBeenCalled();
});

it('publishes a status change event when update transitions the group to aligned', async () => {
const messenger = getRootMessenger();
const providers = [
setupBip44AccountProvider({
name: 'Provider 1',
accounts: [MOCK_WALLET_1_EVM_ACCOUNT],
index: 0,
}),
setupBip44AccountProvider({
name: 'Provider 2',
accounts: [MOCK_WALLET_1_SOL_ACCOUNT],
index: 1,
}),
];
const serviceMessenger = getMultichainAccountServiceMessenger(messenger);
const wallet = new MultichainAccountWallet({
entropySource: MOCK_WALLET_1_ENTROPY_SOURCE,
messenger: serviceMessenger,
providers,
});
const group = new MultichainAccountGroup({
wallet,
groupIndex: 0,
providers,
messenger: serviceMessenger,
});

await group.init({
[providers[0].getName()]: [MOCK_WALLET_1_EVM_ACCOUNT.id],
});

expect(group.status).toBe('missing-accounts');

const mockStatusChange = jest.fn();
serviceMessenger.subscribe(
'MultichainAccountService:multichainAccountGroupStatusChange',
mockStatusChange,
);

await group.update({
[providers[0].getName()]: [MOCK_WALLET_1_EVM_ACCOUNT.id],
[providers[1].getName()]: [MOCK_WALLET_1_SOL_ACCOUNT.id],
});

expect(group.status).toBe('aligned');
expect(mockStatusChange).toHaveBeenCalledTimes(1);
expect(mockStatusChange).toHaveBeenCalledWith(group.id, 'aligned');
});

it('does not publish a status change event when update does not change status', async () => {
const { group, providers, messenger } = await setup({
accounts: [[MOCK_WALLET_1_EVM_ACCOUNT], [MOCK_WALLET_1_SOL_ACCOUNT]],
});

const mockStatusChange = jest.fn();
messenger.subscribe(
'MultichainAccountService:multichainAccountGroupStatusChange',
mockStatusChange,
);

await group.update({
[providers[0].getName()]: [MOCK_WALLET_1_EVM_ACCOUNT.id],
[providers[1].getName()]: [MOCK_WALLET_1_SOL_ACCOUNT.id],
});

expect(group.status).toBe('aligned');
expect(mockStatusChange).not.toHaveBeenCalled();
});
});

describe('isAligned', () => {
it('returns true when every provider has at least one account in the group', () => {
const { group } = setup({
it('returns true when every provider has at least one account in the group', async () => {
const { group } = await setup({
accounts: [[MOCK_WALLET_1_EVM_ACCOUNT], [MOCK_WALLET_1_SOL_ACCOUNT]],
});

expect(group.isAligned()).toBe(true);
});

it('returns false when at least one provider has no accounts in the group', () => {
const { group } = setup({
it('returns false when at least one provider has no accounts in the group', async () => {
const { group } = await setup({
accounts: [
[MOCK_WALLET_1_EVM_ACCOUNT],
[], // second provider has no accounts for this group
Expand All @@ -200,14 +303,14 @@ describe('MultichainAccountGroup', () => {
expect(group.isAligned()).toBe(false);
});

it('returns true for a group with no providers', () => {
const { group } = setup({ accounts: [] });
it('returns true for a group with no providers', async () => {
const { group } = await setup({ accounts: [] });

expect(group.isAligned()).toBe(true);
});

it('returns true when a provider mock is configured to return true despite having no accounts (simulates disabled wrapper)', () => {
const { group, providers } = setup({
it('returns true when a provider mock is configured to return true despite having no accounts (simulates disabled wrapper)', async () => {
const { group, providers } = await setup({
accounts: [
[MOCK_WALLET_1_EVM_ACCOUNT],
[], // second provider has no accounts
Expand Down
Loading
Loading