Skip to content

feat: move notifications i18n keys to backend #9184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zelkibuilds wants to merge 2 commits into
base: feat/update-notifications-controller
Choose a base branch
from
Draft

feat: move notifications i18n keys to backend #9184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8c1778
feat: refactor createOnChainPushNotificationMessages to use BE locali…
zelkibuilds Jun 17, 2026
1851ee2
chore: move key tracking .md out of repo
zelkibuilds Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/notification-services-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- **BREAKING:** `createOnChainPushNotificationMessage` now derives its `title`, `description`, and `ctaLink` from the notification's `template` field and no longer accepts a `translations` argument. ([#9140](https://github.com/MetaMask/core/pull/9140))
- Update call sites to drop the second `translations` argument: `createOnChainPushNotificationMessage(notification)`.
- `ctaLink` is now populated from `template.cta.link` when present.
- **BREAKING:** Remove the `createOnChainPushNotificationMessages` function and the `TranslationKeys` type. Push notification copy is now provided by the API via the notification `template`, so client-side translation keys are no longer required. ([#9140](https://github.com/MetaMask/core/pull/9140))
- Bump `@metamask/utils` from `^11.9.0` to `^11.11.0` ([#9074](https://github.com/MetaMask/core/pull/9074))
- Bump `@metamask/controller-utils` from `^12.1.1` to `^12.2.0` ([#9083](https://github.com/MetaMask/core/pull/9083))
- Bump `@metamask/profile-sync-controller` from `^28.1.1` to `^28.2.0` ([#9119](https://github.com/MetaMask/core/pull/9119))
Expand Down
79 changes: 79 additions & 0 deletions ...on-services-controller/src/NotificationServicesController/mocks/mock-raw-notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ import type { NormalisedAPINotification } from '../types/notification-api/notifi
export function createMockNotificationEthSent(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ETH_SENT,
template: {
image_url: 'https://example.com/eth-sent.svg',
title: 'Funds sent',
body: 'You successfully sent 0.005 ETH',
cta: {
content: 'View transaction',
link: 'https://etherscan.io/tx/eth-sent',
},
},
notification_type: 'on-chain',
id: '3fa85f64-5717-4562-b3fc-2c963f66afa7',
unread: true,
Expand Down Expand Up @@ -55,6 +64,11 @@ export function createMockNotificationEthSent(): NormalisedAPINotification {
export function createMockNotificationEthReceived(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ETH_RECEIVED,
template: {
image_url: 'https://example.com/eth-received.svg',
title: 'Funds received',
body: 'You received 808 ETH',
},
notification_type: 'on-chain',
id: '3fa85f64-5717-4562-b3fc-2c963f66afa8',
unread: true,
Expand Down Expand Up @@ -101,6 +115,11 @@ export function createMockNotificationEthReceived(): NormalisedAPINotification {
export function createMockNotificationERC20Sent(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ERC20_SENT,
template: {
image_url: 'https://example.com/erc20-sent.svg',
title: 'Funds sent',
body: 'You successfully sent 4.96K USDC',
},
notification_type: 'on-chain',
id: '3fa85f64-5717-4562-b3fc-2c963f66afa9',
unread: true,
Expand Down Expand Up @@ -153,6 +172,11 @@ export function createMockNotificationERC20Sent(): NormalisedAPINotification {
export function createMockNotificationERC20Received(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ERC20_RECEIVED,
template: {
image_url: 'https://example.com/erc20-received.svg',
title: 'Funds received',
body: 'You received 8.38B SHIB',
},
notification_type: 'on-chain',
id: '3fa85f64-5717-4562-b3fc-2c963f66afa6',
unread: true,
Expand Down Expand Up @@ -205,6 +229,11 @@ export function createMockNotificationERC20Received(): NormalisedAPINotification
export function createMockNotificationERC721Sent(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ERC721_SENT,
template: {
image_url: 'https://example.com/erc721-sent.svg',
title: 'NFT sent',
body: 'You have successfully sent an NFT',
},
notification_type: 'on-chain',
id: 'a4193058-9814-537e-9df4-79dcac727fb6',
created_at: '2023-11-15T11:08:17.895407Z',
Expand Down Expand Up @@ -260,6 +289,11 @@ export function createMockNotificationERC721Sent(): NormalisedAPINotification {
export function createMockNotificationERC721Received(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ERC721_RECEIVED,
template: {
image_url: 'https://example.com/erc721-received.svg',
title: 'NFT received',
body: 'You received new NFTs',
},
notification_type: 'on-chain',
id: '00a79d24-befa-57ed-a55a-9eb8696e1654',
created_at: '2023-11-14T17:40:52.319281Z',
Expand Down Expand Up @@ -315,6 +349,11 @@ export function createMockNotificationERC721Received(): NormalisedAPINotificatio
export function createMockNotificationERC1155Sent(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ERC1155_SENT,
template: {
image_url: 'https://example.com/erc1155-sent.svg',
title: 'NFT sent',
body: 'You have successfully sent an NFT',
},
notification_type: 'on-chain',
id: 'a09ff9d1-623a-52ab-a3d4-c7c8c9a58362',
created_at: '2023-11-20T20:44:10.110706Z',
Expand Down Expand Up @@ -370,6 +409,11 @@ export function createMockNotificationERC1155Sent(): NormalisedAPINotification {
export function createMockNotificationERC1155Received(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ERC1155_RECEIVED,
template: {
image_url: 'https://example.com/erc1155-received.svg',
title: 'NFT received',
body: 'You received new NFTs',
},
notification_type: 'on-chain',
id: 'b6b93c84-e8dc-54ed-9396-7ea50474843a',
created_at: '2023-11-20T20:44:10.110706Z',
Expand Down Expand Up @@ -425,6 +469,11 @@ export function createMockNotificationERC1155Received(): NormalisedAPINotificati
export function createMockNotificationMetaMaskSwapsCompleted(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.METAMASK_SWAP_COMPLETED,
template: {
image_url: 'https://example.com/swap-completed.svg',
title: 'Swap completed',
body: 'Your MetaMask Swap was successful',
},
notification_type: 'on-chain',
id: '7ddfe6a1-ac52-5ffe-aa40-f04242db4b8b',
created_at: '2023-10-18T13:58:49.854596Z',
Expand Down Expand Up @@ -486,6 +535,11 @@ export function createMockNotificationMetaMaskSwapsCompleted(): NormalisedAPINot
export function createMockNotificationRocketPoolStakeCompleted(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ROCKETPOOL_STAKE_COMPLETED,
template: {
image_url: 'https://example.com/rocketpool-stake-completed.svg',
title: 'Stake complete',
body: 'Your RocketPool stake was successful',
},
notification_type: 'on-chain',
id: 'c2a2f225-b2fb-5d6c-ba56-e27a5c71ffb9',
created_at: '2023-11-20T12:02:48.796824Z',
Expand Down Expand Up @@ -546,6 +600,11 @@ export function createMockNotificationRocketPoolStakeCompleted(): NormalisedAPIN
export function createMockNotificationRocketPoolUnStakeCompleted(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.ROCKETPOOL_UNSTAKE_COMPLETED,
template: {
image_url: 'https://example.com/rocketpool-unstake-completed.svg',
title: 'Unstake complete',
body: 'Your RocketPool unstake was successful',
},
notification_type: 'on-chain',
id: '291ec897-f569-4837-b6c0-21001b198dff',
created_at: '2023-10-19T13:11:10.623042Z',
Expand Down Expand Up @@ -606,6 +665,11 @@ export function createMockNotificationRocketPoolUnStakeCompleted(): NormalisedAP
export function createMockNotificationLidoStakeCompleted(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.LIDO_STAKE_COMPLETED,
template: {
image_url: 'https://example.com/lido-stake-completed.svg',
title: 'Stake complete',
body: 'Your Lido stake was successful',
},
notification_type: 'on-chain',
id: 'ec10d66a-f78f-461f-83c9-609aada8cc50',
created_at: '2023-11-02T22:28:49.970865Z',
Expand Down Expand Up @@ -666,6 +730,11 @@ export function createMockNotificationLidoStakeCompleted(): NormalisedAPINotific
export function createMockNotificationLidoWithdrawalRequested(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.LIDO_WITHDRAWAL_REQUESTED,
template: {
image_url: 'https://example.com/lido-withdrawal-requested.svg',
title: 'Withdrawal requested',
body: 'Your Lido withdrawal request was submitted',
},
notification_type: 'on-chain',
id: 'ef003925-3379-4ba7-9e2d-8218690cadc9',
created_at: '2023-10-18T15:04:02.482526Z',
Expand Down Expand Up @@ -726,6 +795,11 @@ export function createMockNotificationLidoWithdrawalRequested(): NormalisedAPINo
export function createMockNotificationLidoWithdrawalCompleted(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.LIDO_WITHDRAWAL_COMPLETED,
template: {
image_url: 'https://example.com/lido-withdrawal-completed.svg',
title: 'Withdrawal completed',
body: 'Your Lido withdrawal was successful',
},
notification_type: 'on-chain',
id: 'd73df14d-ce73-4f38-bad3-ab028154042f',
created_at: '2023-10-18T16:35:03.147606Z',
Expand Down Expand Up @@ -786,6 +860,11 @@ export function createMockNotificationLidoWithdrawalCompleted(): NormalisedAPINo
export function createMockNotificationLidoReadyToBeWithdrawn(): NormalisedAPINotification {
const mockNotification: NormalisedAPINotification = {
type: TRIGGER_TYPES.LIDO_STAKE_READY_TO_BE_WITHDRAWN,
template: {
image_url: 'https://example.com/lido-ready-to-be-withdrawn.svg',
title: 'Stake ready for withdrawal',
body: 'Your Lido stake is now ready to be withdrawn',
},
notification_type: 'on-chain',
id: 'd73df14d-ce73-4f38-bad3-ab028154042e',
created_at: '2023-10-18T16:35:03.147606Z',
Expand Down
1 change: 1 addition & 0 deletions ...n-services-controller/src/NotificationServicesController/types/notification-api/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ export type components = {
*/
created_at: string;
payload: components['schemas']['OnChainPayload'];
template: components['schemas']['LocalizedNotification'];
};
OnChainPayload: {
/** @example 1 */
Expand Down
Loading