feat: add metadata to stellar trades tx for tx history in bridge status controller#9170
Open
Julink-eth wants to merge 3 commits into
Open
feat: add metadata to stellar trades tx for tx history in bridge status controller#9170Julink-eth wants to merge 3 commits into
Julink-eth wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes the non-EVM snap request payload for all trades that pass asset IDs from quotes; Tron overwrites options so behavior there stays isolated, but Stellar and other non-Tron paths now depend on correct quote asset metadata.
Overview
Stellar bridge trades are wired through submit validation and the non-EVM handler by treating
ChainId.STELLARlike other snap chains (string XDR orStellarTradeData).Snap
signAndSendTransactionrequests now optionally includesourceAssetIdanddestAssetIdfrom the quote inparams.options, passed fromhandleNonEvmTxvia an extendedgetClientRequest. That gives the Stellar snap enough context for transaction history without changing the core request shape for chains that omit those args. Tron still setsvisibleand contracttypeinoptions, which replaces any asset-id options for Tron trades (unchanged Tron-specific behavior).Tests cover Stellar asset ID options (full pair and source-only).
Reviewed by Cursor Bugbot for commit bd8bc27. Bugbot is set up for automated code reviews on this repo. Configure here.