Skip to content

feat: add metadata to stellar trades tx for tx history in bridge status controller#9170

Open
Julink-eth wants to merge 3 commits into
feat/stellar-bridge-controllerfrom
feat/stellar-bridge-status-controller
Open

feat: add metadata to stellar trades tx for tx history in bridge status controller#9170
Julink-eth wants to merge 3 commits into
feat/stellar-bridge-controllerfrom
feat/stellar-bridge-status-controller

Conversation

@Julink-eth

@Julink-eth Julink-eth commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes the non-EVM snap request payload for all trades that pass asset IDs from quotes; Tron overwrites options so behavior there stays isolated, but Stellar and other non-Tron paths now depend on correct quote asset metadata.

Overview
Stellar bridge trades are wired through submit validation and the non-EVM handler by treating ChainId.STELLAR like other snap chains (string XDR or StellarTradeData).

Snap signAndSendTransaction requests now optionally include sourceAssetId and destAssetId from the quote in params.options, passed from handleNonEvmTx via an extended getClientRequest. That gives the Stellar snap enough context for transaction history without changing the core request shape for chains that omit those args. Tron still sets visible and contract type in options, which replaces any asset-id options for Tron trades (unchanged Tron-specific behavior).

Tests cover Stellar asset ID options (full pair and source-only).

Reviewed by Cursor Bugbot for commit bd8bc27. Bugbot is set up for automated code reviews on this repo. Configure here.

@Julink-eth Julink-eth requested a review from a team as a code owner June 17, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant