chore!: Drop Node 18 and 20#9168
Draft
FrederikBolding wants to merge 7 commits into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+142
to
193
| name: Test (22.x) | ||
| runs-on: ubuntu-latest | ||
| needs: prepare | ||
| strategy: | ||
| matrix: | ||
| package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }} | ||
| steps: | ||
| - name: Checkout and setup environment | ||
| uses: MetaMask/action-checkout-and-setup@v2 | ||
| with: | ||
| is-high-risk-environment: false | ||
| node-version: 20.x | ||
| node-version: 22.x | ||
| - run: yarn workspace ${{ matrix.package-name }} run test | ||
| - name: Require clean working directory | ||
| shell: bash | ||
| run: | | ||
| if ! git diff --exit-code; then | ||
| echo "Working tree dirty at end of job" | ||
| exit 1 | ||
| fi | ||
|
|
||
| test-22: | ||
| name: Test (22.x) | ||
| test-24: | ||
| name: Test (24.x) | ||
| runs-on: ubuntu-latest | ||
| needs: prepare | ||
| strategy: | ||
| matrix: | ||
| package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }} | ||
| steps: | ||
| - name: Checkout and setup environment |
Mrtenz
reviewed
Jun 17, 2026
| }, | ||
| "engines": { | ||
| "node": "^18.18 || >=20" | ||
| "node": ">=22" |
Member
There was a problem hiding this comment.
Staged publishing needs at least 22.14.0 IIRC. We also don't need to support Node.js 23 and 25 (both EOL). We can support 26 (current, soon LTS) though:
Suggested change
| "node": ">=22" | |
| "node": "^22.14.0 || ^24 || >=26" |
Member
Author
There was a problem hiding this comment.
I was under the impression we wouldn't want to support 26 until it is LTS.
Member
There was a problem hiding this comment.
I don't see a reason to not support it? It's the current version. AFAIK we supported 24 before it was LTS too in some other repositories too.
Member
Author
There was a problem hiding this comment.
Do we want to use 26 for build and lint then?
Comment on lines
172
to
+197
| @@ -182,8 +182,8 @@ jobs: | |||
| exit 1 | |||
| fi | |||
|
|
|||
| test-22: | |||
| name: Test (22.x) | |||
| test-26: | |||
| name: Test (26.x) | |||
| runs-on: ubuntu-latest | |||
| needs: prepare | |||
| strategy: | |||
| @@ -194,7 +194,7 @@ jobs: | |||
| uses: MetaMask/action-checkout-and-setup@v2 | |||
| with: | |||
| is-high-risk-environment: false | |||
| node-version: 22.x | |||
| node-version: 26.x | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Node 18 and 20 are EOL, we should not support them anymore. This PR makes a breaking change to every single package in the monorepo. This also reduces the number of jobs we need to run in CI.
References
Checklist