Skip to content

chore: fail-open-multichain assets controller filter logic#8580

Draft
sahar-fehri wants to merge 2 commits intomainfrom
chore/fail-open-multichain-assets-controllers-filter-logic
Draft

chore: fail-open-multichain assets controller filter logic#8580
sahar-fehri wants to merge 2 commits intomainfrom
chore/fail-open-multichain-assets-controllers-filter-logic

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

@sahar-fehri sahar-fehri commented Apr 24, 2026

Explanation

Update multichainAssetsControllers logic to be fail-open when filtering out malicious tokens.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

High Risk
Changes the spam/malicious token gating behavior so tokens may be added when the Blockaid bulk-scan call fails, which can reduce protection during outages and affects security-sensitive filtering logic.

Overview
Updates Blockaid-based filtering for newly detected token: CAIP assets to be fail-open: if a bulkScanTokens batch rejects, tokens in that batch are now allowed through instead of being dropped.

Adjusts unit tests to reflect the new behavior, including scenarios where bulkScanTokens throws or where only some scan batches fail, while still filtering tokens explicitly marked Malicious in successful scan responses.

Reviewed by Cursor Bugbot for commit 3be6a8c. Bugbot is set up for automated code reviews on this repo. Configure here.

@sahar-fehri sahar-fehri requested a review from a team as a code owner April 24, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant