chore: fail-open-multichain assets controller filter logic#8580
Draft
sahar-fehri wants to merge 2 commits intomainfrom
Draft
chore: fail-open-multichain assets controller filter logic#8580sahar-fehri wants to merge 2 commits intomainfrom
sahar-fehri wants to merge 2 commits intomainfrom
Conversation
Draft
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Update multichainAssetsControllers logic to be fail-open when filtering out malicious tokens.
References
Checklist
Note
High Risk
Changes the spam/malicious token gating behavior so tokens may be added when the Blockaid bulk-scan call fails, which can reduce protection during outages and affects security-sensitive filtering logic.
Overview
Updates Blockaid-based filtering for newly detected
token:CAIP assets to be fail-open: if abulkScanTokensbatch rejects, tokens in that batch are now allowed through instead of being dropped.Adjusts unit tests to reflect the new behavior, including scenarios where
bulkScanTokensthrows or where only some scan batches fail, while still filtering tokens explicitly markedMaliciousin successful scan responses.Reviewed by Cursor Bugbot for commit 3be6a8c. Bugbot is set up for automated code reviews on this repo. Configure here.