feat(ramps-controller): route RampsEnvironment.Development to dev-api base URLs#8574
Draft
feat(ramps-controller): route RampsEnvironment.Development to dev-api base URLs#8574
Conversation
pkowalski
had a problem deploying
to
default-branch
GitHub Actions
Failure
Contributor
|
@metamaskbot publish-preview |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6a2926f. Configure here.
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
amitabh94
changed the title
amitabh94
changed the title
amitabh94
changed the title
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
…elog Restore staging UAT URLs with regions cache suffix; add Unreleased changelog entry; align Development nocks with dev-api hosts (#8574). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
RampsEnvironment.Developmentpreviously fell through the same branch as staging and sent all traffic to the UAT hosts (on-ramp*.uat-api.cx.metamask.io). This PR gives development its own API hosts on thedev-apisubdomain, aligned with production/staging patterns.Implementation details:
https://on-ramp.dev-api.cx.metamask.io.https://on-ramp-cache.dev-api.cx.metamask.iovia the same${cache}suffix as other environments (sogetCountriesand related regions traffic stay on the cache host).Production, staging, and local base URLs are unchanged.
References
feature/enable-dev-rampson-ramp${cache}.<env>-api.cx.metamask.ioshape as production and staging.Testing
yarn workspace @metamask/ramps-controller jest packages/ramps-controller/src/RampsService.test.tsChecklist
Developmentnow targets dedicated dev hosts instead of UAT)Risk
Low for production/staging users. Consumers that instantiate
RampsService(or the controller) withRampsEnvironment.Developmentwill hit new hostnames; confirm dev-api is reachable and feature-complete for your flows before relying on it.