Conversation
Jwhiles
had a problem deploying
to
default-branch
GitHub Actions
Failure
MoMannn
reviewed
Apr 23, 2026
| export const eip7702AuthorizationStep: Step = { | ||
| name: 'eip-7702-authorization', | ||
| async run({ messenger, address, chainId, delegatorImplAddress }) { | ||
| const existing = await messenger.call( |
Member
There was a problem hiding this comment.
I think existing might not be the best check. If can exist but be a wrong one (example lower nonce). Maybe checking if account is actually upgraded might be better. You can check how the existing upgrade account works and how it checks / saves the ones that are already upgraded.
Because if its already upgraded this step can be skipped altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist