fix: quote request should not be sent of amount of token requested by the user is 0#8554
Open
fix: quote request should not be sent of amount of token requested by the user is 0#8554
Conversation
…for MM Pay transactions
… into acc_override_support
… into acc_override_support
… into acc_override_support
… into acc_override_support
… into acc_override_support
jpuri
commented
Apr 23, 2026
| } | ||
|
|
||
| log('Updating quotes', { transactionId }); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
On money account page token / accountOverride can be updated few times. We need to ensure that quotes is not refetched unless user enters a non-zero token amount. Thus this change is made.
Another approach could be to change methods setTransactionConfig, 'setPaymentToken' to not refresh quote is amount of token requested is zero.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cc70919. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Money account page updated transaction a few times, this change ensure that we get quote only of token amount requested is not 0.
References
Fixes https://consensyssoftware.atlassian.net/browse/CONF-1241
Checklist
Note
Medium Risk
Medium risk: changes quote-refresh behavior and can prevent downstream quote/total updates if token amount detection is incorrect, though scoped to a simple precondition check.
Overview
Prevents unnecessary quote API calls by short-circuiting
updateQuoteswhen all non-skipIfBalancerequired tokens haveamountRaw === '0', while still allowing quoting whenisMaxAmountis true (or when tokens are absent).Adds test coverage for the new skip/allow conditions and documents the fix in the package changelog.
Reviewed by Cursor Bugbot for commit 6efd589. Bugbot is set up for automated code reviews on this repo. Configure here.