feat(analytics-controller): optional skipUUIDv4Check on platform adapter#8543
Open
gauthierpetetin wants to merge 3 commits intomainfrom
Open
feat(analytics-controller): optional skipUUIDv4Check on platform adapter#8543gauthierpetetin wants to merge 3 commits intomainfrom
gauthierpetetin wants to merge 3 commits intomainfrom
Conversation
Allow non-UUIDv4 analyticsId when adapter.skipUUIDv4Check is true. Tighten validateAnalyticsControllerState to a single guard. Add tests and changelog entry. Made-with: Cursor
Fix lint:misc --check (oxfmt) formatting in AnalyticsController and analyticsControllerStateValidator tests. Made-with: Cursor
Satisfy check-changelog by referencing the current pull request. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Allow non-UUIDv4 analyticsId when adapter.skipUUIDv4Check is true, as this is needed in Extension, where IDs are not UUIDv4.
References
NA
Checklist
Note
Medium Risk
Relaxes
analyticsIdvalidation whenskipUUIDv4Checkis enabled on the platform adapter, which could allow inconsistent identifiers if misused but remains opt-in and still rejects empty IDs.Overview
Adds an optional
skipUUIDv4Checkflag toAnalyticsPlatformAdapterand threads it intoAnalyticsControllerstate validation so platforms can use non-UUIDv4analyticsIdvalues while still requiring a non-empty string.Updates the state validator and expands unit tests (controller + validator) to cover the new bypass behavior, and documents the change in the package changelog.
Reviewed by Cursor Bugbot for commit 9f6e598. Bugbot is set up for automated code reviews on this repo. Configure here.