fix(perps): expose spot usdc balance in account state#8535
Draft
fix(perps): expose spot usdc balance in account state#8535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This change fixes a controller gap in @metamask/perps-controller for HyperLiquid accounts that have spot USDC available for trading but zero perps withdrawable balance. The controller already exposed availableBalance, but that field maps to HyperLiquid withdrawable, which is not enough on its own for consumers to determine whether the account is funded enough to trade in this spot-backed flow.
The improvement is a narrow controller update that adds raw spotUsdcBalance to perps account state and populates it in both account fetches and live account updates. This keeps availableBalance unchanged as the withdrawable only value while giving consumers the missing input they need to decide funded state without changing withdraw behavior, order sizing, or other trading calculations.
References
Checklist