Transaction pay controller new assets state#8163
Open
Conversation
bergarces
force-pushed
the
transaction-pay-controller-new-assets-state
branch
from
1a70549 to
1e09ec5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes the data source for balances/metadata/rates behind a feature flag and adds cross-controller messenger calls, which could affect quoting/payment calculations if state shapes or gating logic are wrong.
Overview
Updates
transaction-pay-controllerto optionally source token metadata, balances, and fiat rates from a singleAssetsController:getStateForTransactionPaycall when the newassetsUnifyStateremote feature flag (with app minimum-version gating viaAppMetadataController:getState) is enabled, falling back to the existing per-controllergetStatecalls otherwise.This is wired through the messenger
AllowedActions(breaking type change), adds new dependencies/TS project references, expands mocks/tests to cover the new flag and data source behavior, and removes the unusedgetAllTokenBalanceshelper.Separately,
assets-controllertightensformatExchangeRatesForBridgetypings by reusing canonical@metamask/assets-controllersstate types (dropping local bridge entry types) and adjusts casting to match those types.Written by Cursor Bugbot for commit d883110. This will update automatically on new commits. Configure here.