Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Summary
This PR adds support for a new
predictDepositAndOrdertransaction type in thetransaction-controller. It updates theTransactionTypeenum, associated types, tests, and changelog to recognize and support this combined operation.Why
To enable clients (e.g., Predict integrations) to handle transactions that combine deposit + order placement into a single transaction type, improving consistency and simplifying transaction handling across consumers.
Changes
TransactionType.predictDepositAndOrderto theTransactionTypeenum.CHANGELOG.md.Test Plan
References
Checklist
Note
Low Risk
Low risk additive change limited to TypeScript enum and changelog; main risk is downstream consumers needing to handle the new transaction type value.
Overview
Adds a new
TransactionTypevalue,predictDepositAndOrder, to represent Predict transactions that combine a deposit with an order placement.Updates
CHANGELOG.mdto document the newly supported transaction type.Written by Cursor Bugbot for commit defdf38. This will update automatically on new commits. Configure here.