Skip to content

Threshold scopes ordering #8128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Prithpal-Sooriya wants to merge 2 commits into
base: main
Choose a base branch
from
+48 −9
Draft

Threshold scopes ordering #8128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42ab91e
Fix unordered threshold scope selection
Prithpal-Sooriya Mar 6, 2026
0c53f9c
Fix changelog PR reference for CI
Prithpal-Sooriya Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/remote-feature-flag-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Sort threshold-scoped variations by ascending scope value before selecting a group, so unordered threshold arrays are evaluated correctly. ([#8128](https://github.com/MetaMask/core/pull/8128))

## [4.1.0]

### Added
Expand Down
38 changes: 38 additions & 0 deletions packages/remote-feature-flag-controller/src/remote-feature-flag-controller.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,44 @@ describe('RemoteFeatureFlagController', () => {
});
});

it('selects the lowest matching threshold when threshold scopes are unordered', async () => {
const mockFlags = {
unorderedThresholdFlag: [
{
name: 'control',
scope: { type: 'threshold', value: 1.0 },
value: 'control',
},
{
name: 'treatment',
scope: { type: 'threshold', value: 0.1 },
value: 'treatment',
},
],
};
const clientConfigApiService = buildClientConfigApiService({
remoteFeatureFlags: mockFlags,
});
const controller = createController({
clientConfigApiService,
getMetaMetricsId: () => MOCK_METRICS_ID,
state: {
thresholdCache: {
[`${MOCK_METRICS_ID}:unorderedThresholdFlag`]: 0.05,
},
},
});

await controller.updateRemoteFeatureFlags();

expect(
controller.state.remoteFeatureFlags.unorderedThresholdFlag,
).toStrictEqual({
name: 'treatment',
value: 'treatment',
});
});

it('preserves non-threshold feature flags unchanged', async () => {
const clientConfigApiService = buildClientConfigApiService({
remoteFeatureFlags: MOCK_FLAGS_WITH_THRESHOLD,
Expand Down
15 changes: 6 additions & 9 deletions packages/remote-feature-flag-controller/src/remote-feature-flag-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import type { AbstractClientConfigApiService } from './client-config-api-service
import type {
FeatureFlags,
ServiceResponse,
FeatureFlagScopeValue,
} from './remote-feature-flag-controller-types';
import {
calculateThresholdForFlag,
Expand Down Expand Up @@ -372,15 +371,13 @@ export class RemoteFeatureFlagController extends BaseController<
thresholdCacheUpdates[cacheKey] = thresholdValue;
}

const thresholdScopedFlags = processedValue
.filter(isFeatureFlagWithScopeValue)
.sort((a, b) => a.scope.value - b.scope.value);

const threshold = thresholdValue;
const selectedGroup = processedValue.find(
(featureFlag): featureFlag is FeatureFlagScopeValue => {
if (!isFeatureFlagWithScopeValue(featureFlag)) {
return false;
}

return threshold <= featureFlag.scope.value;
},
const selectedGroup = thresholdScopedFlags.find(
(featureFlag) => threshold <= featureFlag.scope.value,
);
if (selectedGroup) {
processedValue = {
Expand Down
Loading