fix(profile-sync-controller): remove leftover cjs pointers - #10218
Open
mathieuartu wants to merge 3 commits into
Open
fix(profile-sync-controller): remove leftover cjs pointers#10218mathieuartu wants to merge 3 commits into
mathieuartu wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Low Risk
Packaging-only path updates with no runtime logic changes; aligns subpath resolution with the existing ESM-only build.
Overview
After the package went ESM-only, several nested
package.jsonfiles undersdk,auth, anduser-storage(including theirmocksfolders) still pointedmainandtypesat.cjs/.d.ctsartifacts.This PR retargets those entries to
.js/.d.tsso tooling that resolves through those subpaths (e.g. Jest’s module map) loads the actual ESM output instead of stale CommonJS paths. The [Unreleased] changelog adds a Fixed note for the change.Reviewed by Cursor Bugbot for commit 3834dbb. Bugbot is set up for automated code reviews on this repo. Configure here.