feat(account-tree-controller)!: add init + remove updateAccounts - #10191
Draft
ccharly wants to merge 4 commits into
Draft
feat(account-tree-controller)!: add init + remove updateAccounts#10191ccharly wants to merge 4 commits into
init + remove updateAccounts#10191ccharly wants to merge 4 commits into
Conversation
ccharly
force-pushed
the
cc/feat/accounts-controller-init
branch
from
September 11, 2026 11:00
dbab7f3 to
dc4f35d
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Removing the old
updateAccountssince this controller should always be in-sync with theKeyringController's state.Adding
initto force a full re-sync of this controller during startup time. This is required to run potential account object migration automatically (similarly to howupdateAccountswas used in the past).Having a clear
init+clearStatecombo allows to have a better controller's lifecycle which allow other consumers to know when account objects are truly ready.References
N/A
Checklist