Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@
/packages/react-data-query @MetaMask/core-platform
/packages/sample-controllers @MetaMask/core-platform
/packages/selected-network-controller @MetaMask/core-platform
/packages/utils @MetaMask/core-platform
/packages/wallet @MetaMask/core-platform
/packages/wallet-cli @MetaMask/core-platform
/packages/wallet-framework-docs @MetaMask/core-platform
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ yarn skills --reset # clear saved local selection
- [`@metamask/transaction-controller`](packages/transaction-controller)
- [`@metamask/transaction-pay-controller`](packages/transaction-pay-controller)
- [`@metamask/user-operation-controller`](packages/user-operation-controller)
- [`@metamask/utils`](packages/utils)
- [`@metamask/wallet`](packages/wallet)
- [`@metamask/wallet-cli`](packages/wallet-cli)

Expand Down Expand Up @@ -243,6 +244,7 @@ linkStyle default opacity:0.5
transaction_controller(["@metamask/transaction-controller"]);
transaction_pay_controller(["@metamask/transaction-pay-controller"]);
user_operation_controller(["@metamask/user-operation-controller"]);
utils(["@metamask/utils"]);
wallet(["@metamask/wallet"]);
wallet_cli(["@metamask/wallet-cli"]);
account_tree_controller --> accounts_controller;
Expand Down
4 changes: 4 additions & 0 deletions codeowners.ts
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,9 @@ const PACKAGES: Record<string, PackageInfo> = {
'user-operation-controller': {
teams: ['@MetaMask/confirmations'],
},
utils: {
teams: ['@MetaMask/core-platform'],
},
wallet: {
teams: ['@MetaMask/core-platform'],
},
Expand Down Expand Up @@ -569,6 +572,7 @@ function buildTeamSections(): CodeownersSection[] {
buildRuleForPackage('react-data-query'),
buildRuleForPackage('sample-controllers'),
buildRuleForPackage('selected-network-controller'),
buildRuleForPackage('utils'),
buildRuleForPackage('wallet'),
buildRuleForPackage('wallet-cli'),
buildRuleForPackage('wallet-framework-docs'),
Expand Down
90 changes: 90 additions & 0 deletions eslint-suppressions.json
Original file line number Diff line number Diff line change
Expand Up @@ -2007,5 +2007,95 @@
"@typescript-eslint/naming-convention": {
"count": 1
}
},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof 😬 Maybe we should have another PR that fixes these type errors? Ideally we shouldn't introduce the package with a bunch of suppressions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely I was planning to follow up on these, without growing the scope here

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, it might have been better to address these in the utils repo before moving over to core.

"packages/utils/src/assert.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 1
}
},
"packages/utils/src/caip-types.test.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 4
}
},
"packages/utils/src/collections.test.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 2
}
},
"packages/utils/src/collections.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 2
}
},
"packages/utils/src/errors.test.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 3
}
},
"packages/utils/src/errors.ts": {
"no-restricted-syntax": {
"count": 3
}
},
"packages/utils/src/fs.test.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 20
}
},
"packages/utils/src/fs.ts": {
"jsdoc/require-returns": {
"count": 1
}
},
"packages/utils/src/hashing.test.ts": {
"n/no-unsupported-features/node-builtins": {
"count": 9
}
},
"packages/utils/src/hashing.ts": {
"no-restricted-syntax": {
"count": 3
}
},
"packages/utils/src/json.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 1
}
},
"packages/utils/src/json.tst.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 1
}
},
"packages/utils/src/logging.test.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 2
}
},
"packages/utils/src/misc.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 1
}
},
"packages/utils/src/misc.tst.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 1
}
},
"packages/utils/src/mnemonic.ts": {
"jsdoc/tag-lines": {
"count": 1
}
},
"packages/utils/src/promise.ts": {
"jsdoc/tag-lines": {
"count": 1
}
},
"packages/utils/src/unitsConversion.test.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 29
}
}
}
2 changes: 1 addition & 1 deletion jest.config.packages.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ module.exports = {
'^@metamask/json-rpc-engine/v2$': [
'<rootDir>/../json-rpc-engine/src/v2/index.ts',
],
'^@metamask/utils/node$': require.resolve('@metamask/utils/node'),
'^@metamask/utils/node$': ['<rootDir>/../utils/src/node.ts'],
'^@metamask/(.+)$': [
'<rootDir>/../$1/src',
// Some @metamask/* packages we are referencing aren't in this monorepo,
Expand Down
5 changes: 5 additions & 0 deletions jest.config.scripts.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ module.exports = {
// Strip .js extensions from relative imports so Jest resolves them to
// the TypeScript source files.
'^(\\.{1,2}/.+)\\.js$': '$1',
// `@metamask/utils` lives in this repo, so resolve it to its source rather
// than to a build that may not exist yet.
// NOTE: This must be synchronized with the `paths` option in `tsconfig.json`.
'^@metamask/utils/node$': ['<rootDir>/packages/utils/src/node.ts'],
'^@metamask/utils$': ['<rootDir>/packages/utils/src/index.ts'],
'^uuid$': require.resolve('uuid'),
},

Expand Down
90 changes: 0 additions & 90 deletions merged-packages/utils/src/caip-types.test-d.ts

This file was deleted.

26 changes: 0 additions & 26 deletions merged-packages/utils/src/hex.test-d.ts

This file was deleted.

Loading
Loading