feat(ramps-controller): add neobank onboarding stage lookup - #10116
Draft
roz0n wants to merge 6 commits into
Draft
feat(ramps-controller): add neobank onboarding stage lookup#10116roz0n wants to merge 6 commits into
roz0n wants to merge 6 commits into
Conversation
roz0n
added a commit
that referenced
this pull request
Sep 4, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
roz0n
added a commit
that referenced
this pull request
Sep 8, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
roz0n
force-pushed
the
feat/TRAM-3916-neobank-state-machine
branch
from
September 8, 2026 15:12
9883790 to
8928d7c
Compare
roz0n
changed the title
This was referenced Sep 8, 2026
roz0n
commented
Sep 8, 2026
| * SumSub + idOS provider disclaimers (submitted as a batch — if either is | ||
| * missing after a partial accept, Mobile routes back to Terms 2). | ||
| */ | ||
| export enum NeobankOnboardingStage { |
Author
There was a problem hiding this comment.
Note to self: Review final states before merging
Author
There was a problem hiding this comment.
Reviewed the final states against KYC controller statuses and the SumSub launch rule (mount KYCPage + page hook; do not launch from a router method).
Kept the funnel: NoUser / EmailOtp / VendorTerms / ProviderTerms → KYC stages → wallet → autoramp → LookupFailed. Core still returns a stage only.
Derivation fixes in c05e25b:
abandonedand retryable SumSubfailed→KycStartedIncomplete(KYCPage hook may resume / relaunch)vendorProcessinganduserStatus === pending→KycPending(do not launch the SDK)phase === error→LookupFailed, not a terminal KYC rejectform/checkcount as in-progress, notKycNotStartedKycRejectedis onlyuserStatus === terminal-failure
Mobile should map KycNotStarted / KycStartedIncomplete / KycNeedsReview to KYCPage, and T&C stages elsewhere. No LaunchSumsub stage or Core launch action.
Give Mobile a single idempotent Core action that refreshes KYC/wallet/autoramp signals and returns the Money Account onboarding stage without navigating or auto-submitting. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…leased Keep the onboarding stage entry out of released 20.3.0 so the changelog check can see it, and format the hydrateNeobankStore tests. Co-authored-by: Cursor <cursoragent@cursor.com>
roz0n
force-pushed
the
feat/TRAM-3916-neobank-state-machine
branch
from
September 11, 2026 14:16
8928d7c to
49def7a
Compare
Treat abandoned/retryable SumSub as KYCPage-resume, vendorProcessing as pending without launching the SDK, and controller errors as lookup failures rather than terminal rejects. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
roz0n
commented
Sep 11, 2026
| * registration / autoramp checks after KYC is complete. | ||
| * @returns The derived {@link NeobankOnboardingStage}. | ||
| */ | ||
| async hydrateNeobankStore({ |
Author
There was a problem hiding this comment.
GW: do we need walletAddress passed here? (might be ok)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds
RampsController.hydrateNeobankStore({ walletAddress })and persistedstate.neobankso clients can resume Money Account onboarding from authoritative Core state.The lookup refreshes KYC first, then checks wallet registration and autoramp readiness only after KYC completes. It returns one
NeobankOnboardingStage. It does not navigate, launch SumSub, register a wallet, or create an autoramp.Final KYC behavior:
abandonedor retryablefailedreturnsKycStartedIncomplete.vendorProcessingand user statuspendingreturnKycPendingand must not relaunch the SDK.errorreturnsLookupFailed.KycRejectedis reserved for user statusterminal-failure.Hosts must delegate the exported required KYC actions.
References
Checklist