Feat/cyber corp ecosystem upgradeability #56
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update SAFTE-RegD-US-Company
Feat delegation merge
…ding existing DealManagers
…ic-rounds.s.sol and add corresponding tests
…y' into feat/arbitrary-legal-doc-signer # Conflicts: # test/CyberAgreementRegistryTest.t.sol
…ary legal signing. Add tests
Feat/arbitrary legal doc signer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
script/upgrade-legacy-cybercorps.s.solwill migrate legacy contracts (ex.CyberCorp,DealManager,IssuanceManager) as they require individual maintenance to adopt new co-approval-upgrade modelscript/res/known-cyber-corps.jsonfor all known legacy cyber corps for upgradesUpdated
script/upgrade-public-rounds.s.solwill perform all upgrades except migrating legacy deal managers (done separately byscript/upgrade-legacy-cybercorps.s.solinstead):CyberAgreementRegistryCyberCorpFactoryCyberCorpSingleFactoryIssuanceManagerFactoryDealManagerFactoryRoundManagerFactoryAll individual company contracts (
CyberCorp,IssuanceManager,DealManager,RoundManager) are now individually upgradeable given MetaLeX & company owner's co-approvalCyberCertPrinterandCyberScripremain as beacon proxies but will also require MetaLeX & company owner's co-approval to upgradeFixed contract size issues on
CyberCertPrinterFixed slot conflict in upgraded
DealManagerFixed CICD. Need @merisman 's help to add corresponding secrets to repo though. Here's a working example in my internal repo
Removed